Fix livesync on multiple devices when app is not installed #1502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
When you try to livesync on multiple devices and application is not installed on more than one, calling `tns livesync <platform>` installs the application only on one of them. There's warning in the output that the application is not installed for each of the devices, but it is installed only on one of them. The problem is the current logic that is executed for each device - as we want to build only one, in case the app is already built, we've skipped the install part for all devices except the first one. So we have to build once, but install the built package on all devices where the app does not exist.
rosen-vladimirov
force-pushed
the
vladimirov/fix-ls-not-installed-multi-devices
branch
from
29dffbc to
97bee03
Compare
rosen-vladimirov
added a commit
that referenced
this pull request
Feb 18, 2016
…alled-multi-devices Fix livesync on multiple devices when app is not installed
rosen-vladimirov
deleted the
vladimirov/fix-ls-not-installed-multi-devices
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you try to livesync on multiple devices and application is not installed on more than one, calling
tns livesync <platform>installs the application only on one of them.There's warning in the output that the application is not installed for each of the devices, but it is installed only on one of them.
The problem is the current logic that is executed for each device - as we want to build only one, in case the app is already built, we've skipped the install part for all devices except the first one.
So we have to build once, but install the built package on all devices where the app does not exist.
Fixes #1503