Delete project directory if project creation doesn't succeed #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| projectDir = path.join(projectDir, projectName); | ||
| this.$fs.createDirectory(projectDir).wait(); | ||
| projectDir = path.join(projectDir, projectName); | ||
| this.$fs.createDirectory(projectDir).wait(); |
There was a problem hiding this comment.
If createDirectory() fails, then the catch block will try to deleteDir() it. Is this intended?
Also, I think the code which cannot throw, which is all the code up to this line, should be outside the try block.
|
|
||
| this.$logger.out("Project successfully created."); | ||
| } catch(ex) { |
There was a problem hiding this comment.
It is better to name this just e or err because it is not an Exception but Error.
|
You can extract |
|
👍 |
Fatme
added a commit
that referenced
this pull request
Aug 8, 2014
Delete project directory if project creation doesn't succeed
e2l3n
pushed a commit
to e2l3n/nativescript-cli
that referenced
this pull request
Aug 31, 2015
rigor789
pushed a commit
that referenced
this pull request
Feb 7, 2022
…-local Fix check for android local builds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.