Some improvements for AndroidManifest in App_Resources #1468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rosen-vladimirov
commented
Feb 11, 2016
rosen-vladimirov
commented
- Correct the code, so AndroidManifest will not be backed up in case we are unable to find the manifest in the template (current code was always creating the backup and reverting it in case it fails on the extraction from template).
- Fix backup name - use guid in case AndroidManifest.backup exists.
|
👍 |
rosen-vladimirov
force-pushed
the
vladimirov/fix-android-manifest-again
branch
from
7853fe5 to
ec546e9
Compare
|
👍 |
* Correct the code, so AndroidManifest will not be backed up in case we are unable to find the manifest in the template (current code was always creating the backup and reverting it in case it fails on the extraction from template). * Fix backup name - use guid in case AndroidManifest.backup exists.
rosen-vladimirov
force-pushed
the
vladimirov/fix-android-manifest-again
branch
from
ec546e9 to
f800172
Compare
rosen-vladimirov
added a commit
that referenced
this pull request
Feb 11, 2016
…ifest-again Some improvements for AndroidManifest in App_Resources
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.