Fix detection of changed shasums #1464
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
run ci |
Currently we are validating only the shasum of the files in order to detect which one are changed and sync only them. However this is not correct as the file may be on a different location, but without changing its size. Also in case you copy some of your files, their shasums might be the same as the original file. In case the original file is already synced, its hash size will be found in the "oldShasums" and the new file will not be copied. Validate by using both path and hash. Fix unit tests and add some new ones.
rosen-vladimirov
force-pushed
the
vladimirov/fix-livesync
branch
from
3f3e7fc to
29054b5
Compare
rosen-vladimirov
added a commit
that referenced
this pull request
Feb 10, 2016
Fix detection of changed shasums
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we are validating only the shasum of the files in order to detect which one are changed and sync only them.
However this is not correct as the file may be on a different location, but without changing its size.
Also in case you copy some of your files, their shasums might be the same as the original file.
In case the original file is already synced, its hash size will be found in the "oldShasums" and the new file will not be copied.
Validate by using both path and hash.
Fix unit tests and add some new ones.