Use Debugger UI from a dedicated npm package #1442
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| import * as net from "net"; | ||
| import * as path from "path"; | ||
| import * as semver from "semver"; | ||
| import byline = require("byline"); | ||
|
|
||
| let InspectorBackendPort = 18181; | ||
| const InspectorBackendPort = 18181; | ||
| const inspectorAppName = "NativeScript Inspector.app"; |
There was a problem hiding this comment.
why the first constant name InspectorBackendPort starts with capital letter and the others do not
There was a problem hiding this comment.
Because it was old code and I missed it. Will fix it.
teobugslayer
force-pushed
the
separate-debugger-ui
branch
from
810cb77 to
5bbbfb6
Compare
teobugslayer
force-pushed
the
separate-debugger-ui
branch
from
5bbbfb6 to
e25208d
Compare
|
👍 |
teobugslayer
added a commit
that referenced
this pull request
Feb 2, 2016
Use Debugger UI from a dedicated npm package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See NativeScript/ios-jsc#474