Skip to content

Verify CocoaPods #1385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 11, 2016
Merged

Verify CocoaPods #1385

merged 1 commit into from
Jan 11, 2016

Conversation

teobugslayer
Copy link
Contributor

See #1294

How it works:

  • install iOS runtime into a temporary directory
  • create a simple Podfile into the template project
  • run (sandobox-)pod
  • verify nothing breaks

@teobugslayer teobugslayer force-pushed the totev/verify-cocoapods branch from 5488199 to b33c9da Compare January 8, 2016 17:08
@rosen-vladimirov
Copy link
Contributor

hm, why should we create new project, add platform and verify pod install command after that. Do we want to validate that project with pods can be created or that pods are useful on the machine?
I prefer to create Podfile in a temp dir and call pod install. Could this be done or we need some files from the runtime?

@teobugslayer
Copy link
Contributor Author

Well, CocoaPods need a Xcode project to work on and that was the easiest way I could think of creating one.

@rosen-vladimirov
Copy link
Contributor

We can print dots while waiting for pod install (we have a method in helpers that does this :) )

@teobugslayer
Copy link
Contributor Author

@rosen-vladimirov, without existing {N} project, CocoaPods complains with [!] Could not automatically select an Xcode project.

@rosen-vladimirov
Copy link
Contributor

Can we mock it - for example we can add one default proj file in our resources, copy it to temp folder, create Podfile there and call pod install
There are many, many reasons why tns create app1 && tns platform add ios may fail and it will break doctor command. Do we want this?

@teobugslayer teobugslayer force-pushed the totev/verify-cocoapods branch 3 times, most recently from 54498b2 to b7691b2 Compare January 11, 2016 14:33
let temp = require("temp");
temp.track();
let projDir = temp.mkdirSync("nativescript-check-cocoapods");
this.$npm.install("tns-ios", projDir).wait();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we should try-catch this one as well. As we know - npm fails sometimes and in this case our doctor command will fail

@teobugslayer teobugslayer force-pushed the totev/verify-cocoapods branch from b7691b2 to 5cc9485 Compare January 11, 2016 14:40
@teobugslayer teobugslayer force-pushed the totev/verify-cocoapods branch from 5cc9485 to 96112ef Compare January 11, 2016 14:43
@rosen-vladimirov
Copy link
Contributor

👍

teobugslayer added a commit that referenced this pull request Jan 11, 2016
@teobugslayer teobugslayer merged commit bb223dc into master Jan 11, 2016
@teobugslayer teobugslayer deleted the totev/verify-cocoapods branch January 11, 2016 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants