Fix baseConfig option for iOS #1383
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `--baseConfig` option is used for `tns platform add ios`, the command fails with ENOTEMPTY. The reason is that we copy the baseConfig file before creating correct directories and when we try to rename __PROJECT_NAME__ dir to real project name, it fails as we have already created this dir.
|
👍 |
1 similar comment
|
👍 |
rosen-vladimirov
added a commit
that referenced
this pull request
Jan 8, 2016
Fix baseConfig option for iOS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
--baseConfigoption is used fortns platform add ios, the command fails with ENOTEMPTY.The reason is that we copy the baseConfig file before creating correct directories and when we try to rename
__PROJECT_NAME__dir to real project name, it fails as we have already created this dir.