Skip to content

support no-client command on android debug commands #1379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 8, 2016

Conversation

blagoev
Copy link
Contributor

@blagoev blagoev commented Jan 7, 2016

There is no help that this command argument works on android. Provide one

this.openDebuggerClient(AndroidDebugService.DEFAULT_NODE_INSPECTOR_URL + "?port=" + port);

if (this.$options.client)
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please move the { on the line above

teobugslayer added a commit that referenced this pull request Jan 8, 2016
support no-client command on android debug commands
@teobugslayer teobugslayer merged commit 331eba0 into master Jan 8, 2016
@teobugslayer teobugslayer deleted the no-client-command-android branch January 8, 2016 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants