Init command should not force tns-core-modules version #1356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently `tns init` command forces the application to use the default version of tns-core-modules. For example in case your CLI is version 1.4.3, `tns init` in non-interactive terminal will set version 1.4.0 (latest 1.4.x) of tns-core-modules even in case you already have defined your version in your package.json Use --tnsCoreModules option by default - if it is specified, it has highest priority. In case the console is not interactive, check if package.json has entry in dependencies section for tns-core-modules and use it. In case the console is interactive, show all available versions to the user and let him pick up the one he wants. In case the console is not interactive and the package.json does not have entry for `tns-core-modules`, use the default logic.
|
👍 |
1 similar comment
|
👍 |
|
Test PASSed. |
rosen-vladimirov
added a commit
that referenced
this pull request
Dec 17, 2015
…mmand Init command should not force tns-core-modules version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
tns initcommand forces the application to use the default version of tns-core-modules.For example in case your CLI is version 1.4.3,
tns initin non-interactive terminal will set version 1.4.0 (latest 1.4.x) of tns-core-modules even in case you already have defined your version in your package.jsonUse --tnsCoreModules option by default - if it is specified, it has highest priority.
In case the console is not interactive, check if package.json has entry in dependencies section for tns-core-modules and use it.
In case the console is interactive, show all available versions to the user and let him pick up the one he wants.
In case the console is not interactive and the package.json does not have entry for
tns-core-modules, use the default logic.Targeting release branch as this feature is required for AppBuilder integration.