-
-
Notifications
You must be signed in to change notification settings - Fork 197
Mac setup improvements #1250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mac setup improvements #1250
Conversation
teobugslayer
commented
Nov 25, 2015
- rewritten as pure Ruby script, no longer tries to be a brew formula
- update installed node to 4 LTS
Test PASSed. |
ping @ErjanGavalji @dtopuzov |
sha256 "813e1b809c094d29255191c14892a32a498e2ca298abbf5ce5cb4081faa4e88f" | ||
puts "Installing Android SDK" | ||
system('brew install android-sdk') | ||
system('echo "export ANDROID_HOME=/usr/local/opt/android-sdk" >> ~/.bash_profile') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will not work with custom shells like zsh.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.profile might be the better option, for it gets considered by both zsh and bash. It will still not work in fancier shells like fish, but I suggest that bash and zsh are a good coverage.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great suggestion, I will change the file.
- rewritten as pure Ruby script, no longer tries to be a brew formula - update installed node to 4 LTS
6321fa0
to
50966cf
Compare
Test PASSed. |
All comments are addressed |
👍 |
system('brew install homebrew/versions/node012') | ||
puts "Installing Android SDK" | ||
system('brew install android-sdk') | ||
system('echo "export ANDROID_HOME=/usr/local/opt/android-sdk" >> ~/.profile') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure that zsh loads .profile
: http://superuser.com/questions/187639/zsh-not-hitting-profile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so sad...
still, let's use the .profile file instead of sticking to the bash-specific .bash_profile :)
👍 |
We already have zsh support for our completion so I'm proposing that we add it here as well 😄 |