Skip to content

Mac setup improvements #1250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 27, 2015
Merged

Mac setup improvements #1250

merged 1 commit into from
Nov 27, 2015

Conversation

teobugslayer
Copy link
Contributor

  • rewritten as pure Ruby script, no longer tries to be a brew formula
  • update installed node to 4 LTS

@ns-bot
Copy link

ns-bot commented Nov 25, 2015

Test PASSed.

@teobugslayer
Copy link
Contributor Author

ping @ErjanGavalji @dtopuzov

sha256 "813e1b809c094d29255191c14892a32a498e2ca298abbf5ce5cb4081faa4e88f"
puts "Installing Android SDK"
system('brew install android-sdk')
system('echo "export ANDROID_HOME=/usr/local/opt/android-sdk" >> ~/.bash_profile')
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will not work with custom shells like zsh.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.profile might be the better option, for it gets considered by both zsh and bash. It will still not work in fancier shells like fish, but I suggest that bash and zsh are a good coverage.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great suggestion, I will change the file.

- rewritten as pure Ruby script, no longer tries to be a brew formula
- update installed node to 4 LTS
@ns-bot
Copy link

ns-bot commented Nov 26, 2015

Test PASSed.

@teobugslayer
Copy link
Contributor Author

All comments are addressed

@rosen-vladimirov
Copy link
Contributor

👍

system('brew install homebrew/versions/node012')
puts "Installing Android SDK"
system('brew install android-sdk')
system('echo "export ANDROID_HOME=/usr/local/opt/android-sdk" >> ~/.profile')
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so sad...
still, let's use the .profile file instead of sticking to the bash-specific .bash_profile :)

@ErjanGavalji
Copy link
Contributor

👍

teobugslayer added a commit that referenced this pull request Nov 27, 2015
@teobugslayer teobugslayer merged commit bb15221 into master Nov 27, 2015
@teobugslayer teobugslayer deleted the totev/setup-v3 branch November 27, 2015 08:52
@ligaz
Copy link

ligaz commented Nov 30, 2015

We already have zsh support for our completion so I'm proposing that we add it here as well 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants