Fix cocoapods check and add unit tests for doctor service #1248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test FAILed. |
rosen-vladimirov
force-pushed
the
vladimirov/fix-cocoapods-check
branch
2 times, most recently
from
44b19bd to
1722709
Compare
|
Test FAILed. |
1 similar comment
|
Test FAILed. |
rosen-vladimirov
force-pushed
the
vladimirov/fix-cocoapods-check
branch
from
1722709 to
a428275
Compare
|
Test FAILed. |
rosen-vladimirov
force-pushed
the
vladimirov/fix-cocoapods-check
branch
from
a428275 to
d78a885
Compare
|
Test PASSed. |
rosen-vladimirov
force-pushed
the
vladimirov/fix-cocoapods-check
branch
from
d78a885 to
a16713c
Compare
|
Test PASSed. |
|
👍 |
When cocoapods are not installed on Mac machine, doctor is failing. Fix this by skipping match check in case pods are not installed. Add basic unit tests for doctor service. Add unit test for the failing cocoapods check.
rosen-vladimirov
force-pushed
the
vladimirov/fix-cocoapods-check
branch
from
a16713c to
cea0f36
Compare
|
Test PASSed. |
rosen-vladimirov
added a commit
that referenced
this pull request
Nov 26, 2015
…heck Fix cocoapods check and add unit tests for doctor service
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When cocoapods are not installed on Mac machine, doctor is failing.
Fix this by skipping match check in case pods are not installed.
Add basic unit tests for doctor service.
Add unit test for the failing cocoapods check.