Android debugger unixsockets #1227
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oid debugger that uses unix named sockets related to pull #273
|
Test FAILed. |
| }); | ||
|
|
||
| server.on('error', function (err: any) { | ||
| future.return(false); |
|
@Fatme : Please fix all in place. This commit should be regarded as a reference for the necessary fixes that correspond to the related one in the engine. |
blagoev
added a commit
to NativeScript/android
that referenced
this pull request
Dec 20, 2015
Fixes: refactored and fixed debugger for issue (issue #112) … fix debugger reattach (issue #266) fix debugger disconnect when client disconnects (issue #270) and fix for sdcard permission issues the original pull was here #273 the corresponding CLI changes are here NativeScript/nativescript-cli#1227
blagoev
added a commit
to NativeScript/android
that referenced
this pull request
Jan 6, 2016
Fixes: refactored and fixed debugger for issue (issue #112) … fix debugger reattach (issue #266) fix debugger disconnect when client disconnects (issue #270) and fix for sdcard permission issues the original pull was here #273 the corresponding CLI changes are here NativeScript/nativescript-cli#1227
|
reimplemented in #1373 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is releated to the changes here #273. A help is needed to merge this into master and then investigate what issues there might be in app builder CLI.
The long story short. The android debugger now uses named sockets instead of ports hence the code rewrite in adndroid-debug-service to accommodate for that.
Contact me directly in order to merge this successfully into the respected main branches.