Fix doctor command for android and adb #1170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| public getPathToAdbFromAndroidHome(): IFuture<string> { | ||
| return (() => { | ||
| if(this.androidHome) { | ||
| let pathToAdb = path.join(this.androidHome, "platform-tools", "adb") + (this.$hostInfo.isWindows ? ".exe" : ""); |
There was a problem hiding this comment.
Do you really need to take care of the .exe suffix? It should work without it.
There was a problem hiding this comment.
Not sure if it works without, it but it works with .exe and CI is green :) 💯
There was a problem hiding this comment.
yep, I do not need this, I'll remove it (I've added it for debugging purposes and I forgot to remove it).
rosen-vladimirov
force-pushed
the
vladimirov/fix-doctor-command-again
branch
from
80044b5 to
349082c
Compare
|
👍 |
Fix doctor command, which checks adb and android incorrectly. Pass correct paths for verification. Also make sure "No issues were detected" is printed when there are no issues.
Add SysInfo class that extends the base SysInfoBase class by calling `getSysInfo` method with correct paths to android and adb. Remove check for java, as javac check is enough for us.
rosen-vladimirov
force-pushed
the
vladimirov/fix-doctor-command-again
branch
from
349082c to
b150659
Compare
|
Test PASSed. |
|
Do not forget to squash, 👍 |
rosen-vladimirov
added a commit
that referenced
this pull request
Nov 11, 2015
…and-again Fix doctor command for android and adb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix doctor command, which checks adb and android incorrectly. Pass correct paths for verification.
Also make sure "No issues were detected" is printed when there are no issues.