Skip sha verification when a package is not on npmjs.org #1169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -137,13 +137,21 @@ export class NpmInstallationManager implements INpmInstallationManager { | |||
| return ((): boolean => { | |||
| let shasumProperty = "dist.shasum"; | |||
| let cachedPackagePath = this.getCachedPackagePath(packageName, version); | |||
| let realShasum = this.$npm.view(`${packageName}@${version}`, shasumProperty).wait()[version][shasumProperty]; | |||
| let packageInfo = this.$npm.view(`${packageName}@${version}`, shasumProperty).wait(); | |||
There was a problem hiding this comment.
in case the package is not in npm, this code will fail and we'll never get to the next if... or I'm totally missing something.
My test:
$ npm view app12354242
npm ERR! Windows_NT 6.3.9600
npm ERR! argv "c:\\Program Files\\nodejs\\node.exe" "c:\\Program Files\\nodejs\\node_modules\\npm\\bin\\npm-cli.js" "view" "app12354242"
npm ERR! node v0.12.7
npm ERR! npm v2.11.3
npm ERR! code E404
npm ERR! 404 Registry returned 404 for GET on https://registry.npmjs.org/app12354242
npm ERR! 404
npm ERR! 404 'app12354242' is not in the npm registry.
npm ERR! 404 You should bug the author to publish it (or use the name yourself!)
npm ERR! 404
npm ERR! 404 Note that you can also install from a
npm ERR! 404 tarball, folder, http url, or git url.
npm ERR! Please include the following file with any support request:
npm ERR! d:\Work\nativescript-cli\npm-debug.log
|
Test PASSed. |
|
On node 4.2.2 and 0.12 it returns an empty object. |
|
👍 |
teobugslayer
added a commit
that referenced
this pull request
Nov 10, 2015
Skip sha verification when a package is not on npmjs.org
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1147