Improve Getting-started for Android #1159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test PASSed. |
| }).future<string>()(); | ||
| } | ||
|
|
||
| private trySpawnAndroidHelp(androidPath: string): IFuture<boolean>{ |
There was a problem hiding this comment.
Isn't it better to name this method trySetAndroidPath? It is unclear when reading getPathToAndroidExecutable that trySpawnAndroidHelp actually sets the path to the executable.
There was a problem hiding this comment.
yes, I've changed the logic to set the path in this method, but I forgot to rename it 😺
rosen-vladimirov
force-pushed
the
vladimirov/improve-doctor-command
branch
from
63e5852 to
c7324b6
Compare
|
Test PASSed. |
rosen-vladimirov
force-pushed
the
vladimirov/improve-doctor-command
branch
from
c7324b6 to
5983804
Compare
|
Test FAILed. |
|
run ci |
|
Test FAILed. |
|
run ci |
|
Test PASSed. |
rosen-vladimirov
force-pushed
the
vladimirov/improve-doctor-command
branch
from
5983804 to
d568cfe
Compare
|
Test PASSed. |
rosen-vladimirov
force-pushed
the
vladimirov/improve-doctor-command
branch
from
d568cfe to
5706e92
Compare
|
Test PASSed. |
rosen-vladimirov
force-pushed
the
vladimirov/improve-doctor-command
branch
from
5706e92 to
c9a612a
Compare
|
Test PASSed. |
| } | ||
| } else { | ||
| hasProblemWithJavaVersion = true; | ||
| this.printMessage("Error executing command 'javac'. Make sure you have java installed and set JAVA_HOME environment variable.", additionalMessage); |
There was a problem hiding this comment.
It is not enough to install java (the JRE). you need to install JDK. This should be reflected in the message.
rosen-vladimirov
force-pushed
the
vladimirov/improve-doctor-command
branch
from
c9a612a to
67dee5d
Compare
|
Test PASSed. |
rosen-vladimirov
force-pushed
the
vladimirov/improve-doctor-command
branch
from
67dee5d to
aa33c33
Compare
|
Test PASSed. |
|
👍 |
* Remove requirement to have `<android-sdk>/tools` and `<android-sdk>/platform-tools` directories to your PATH - use them based on ANDROID_HOME variable. * Based on the above point - replace all calls to `android` directly with correct path to the `android` executable. * Remove requirement for JAVA added in your PATH - validate it by using JAVA_HOME. * Improve error messages when ANDROID_HOME is not set - for example warning about missing compile SDK will inform you in case ANDROID_HOME is not set. * Improve ANDROID_HOME checks - validate that directories like "extras", "tools", "platform-tools" exist (at least on of them). * Validate JAVA version in doctor command. * Sometimes `build-tools` directories are not called with version(`22.0.1`), but have the name: `build-tools-22.0.1` - make sure we will be able to use such dirs * Skip cocoapods warnings on Linux and Windows (for `tns doctor` command).
rosen-vladimirov
force-pushed
the
vladimirov/improve-doctor-command
branch
from
aa33c33 to
d415621
Compare
|
Test PASSed. |
rosen-vladimirov
added a commit
that referenced
this pull request
Nov 9, 2015
…command Improve Getting-started for Android
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<android-sdk>/toolsand<android-sdk>/platform-toolsdirectories to your PATH - use them based on ANDROID_HOME variable.androiddirectly with correct path to theandroidexecutable.build-toolsdirectories are not called with version(22.0.1), but have the name:build-tools-22.0.1- make sure we will be able to use such dirstns doctorcommand).