Skip to content

Support for include.gradle from plugins #1135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 11, 2015
Merged

Support for include.gradle from plugins #1135

merged 5 commits into from
Nov 11, 2015

Conversation

Fatme
Copy link
Contributor

@Fatme Fatme commented Nov 2, 2015

#1048

This PR should be merged after the corresponding in android runtime.

@@ -101,6 +103,8 @@ export class ProjectData implements IProjectData {
this.projectName = this.$projectHelper.sanitizeName(path.basename(projectDir));
this.platformsDir = path.join(projectDir, "platforms");
this.projectFilePath = path.join(projectDir, this.$staticConfig.PROJECT_FILE_NAME);
this.appDirectoryPath = path.join(projectDir, "app");
this.appResourcesDirectoryPath = path.join(projectDir, "app", "App_Resources");
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a constant for App_Resources.

@Fatme Fatme force-pushed the fatme/aapt branch 3 times, most recently from f5d78fc to 825bdf4 Compare November 3, 2015 08:17
@ns-bot
Copy link

ns-bot commented Nov 3, 2015

Test PASSed.

@@ -1,6 +1,7 @@
///<reference path=".d.ts"/>
"use strict";

import constants = require("./constants");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use ES6 imports

@teobugslayer
Copy link
Contributor

👍 squash and go

@ns-bot
Copy link

ns-bot commented Nov 6, 2015

Test FAILed.

@dtopuzov dtopuzov added this to the 1.5.0 milestone Nov 11, 2015
@teobugslayer teobugslayer self-assigned this Nov 11, 2015
@ns-bot
Copy link

ns-bot commented Nov 11, 2015

Test PASSed.

@rosen-vladimirov
Copy link
Contributor

👍

teobugslayer added a commit that referenced this pull request Nov 11, 2015
Support for include.gradle from plugins
@teobugslayer teobugslayer merged commit f39fd09 into master Nov 11, 2015
@teobugslayer teobugslayer deleted the fatme/aapt branch November 11, 2015 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants