-
-
Notifications
You must be signed in to change notification settings - Fork 197
Support for include.gradle from plugins #1135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@@ -101,6 +103,8 @@ export class ProjectData implements IProjectData { | |||
this.projectName = this.$projectHelper.sanitizeName(path.basename(projectDir)); | |||
this.platformsDir = path.join(projectDir, "platforms"); | |||
this.projectFilePath = path.join(projectDir, this.$staticConfig.PROJECT_FILE_NAME); | |||
this.appDirectoryPath = path.join(projectDir, "app"); | |||
this.appResourcesDirectoryPath = path.join(projectDir, "app", "App_Resources"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a constant for App_Resources
.
f5d78fc
to
825bdf4
Compare
Test PASSed. |
@@ -1,6 +1,7 @@ | |||
///<reference path=".d.ts"/> | |||
"use strict"; | |||
|
|||
import constants = require("./constants"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use ES6 imports
👍 squash and go |
Test FAILed. |
af2381b
to
cb2c4b5
Compare
Test PASSed. |
👍 |
teobugslayer
added a commit
that referenced
this pull request
Nov 11, 2015
Support for include.gradle from plugins
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1048
This PR should be merged after the corresponding in android runtime.