Fix fs copyFile when source and target are the same #1108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosen-vladimirov
force-pushed
the
vladimirov/fix-copyFile
branch
from
c734ba5 to
a04ac00
Compare
|
Test PASSed. |
1 similar comment
|
Test PASSed. |
rosen-vladimirov
force-pushed
the
vladimirov/fix-copyFile
branch
from
a04ac00 to
638ad5b
Compare
|
Test PASSed. |
|
👍 |
rosen-vladimirov
force-pushed
the
vladimirov/fix-copyFile
branch
from
638ad5b to
85e8949
Compare
|
Test PASSed. |
When source and target file are the same, copyFile produces empty file. Add check and if they are the same, do not execute any action. Move fs tests from appbuilder-cli to common. Add tests for copyFile.
rosen-vladimirov
force-pushed
the
vladimirov/fix-copyFile
branch
from
85e8949 to
3557378
Compare
|
Test PASSed. |
rosen-vladimirov
added a commit
that referenced
this pull request
Oct 27, 2015
Fix fs copyFile when source and target are the same
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When source and target file are the same, copyFile produces empty file.
Add check and if they are the same, do not execute any action.
Move fs tests from appbuilder-cli to common. Add tests for copyFile.