Check cocoapods availability before executing pod install #1104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test FAILed. |
|
👍 |
Fatme
force-pushed
the
fatme/pod-availability
branch
from
5f64acd to
0c22afb
Compare
|
Test PASSed. |
| // Check availability | ||
| try { | ||
| this.$childProcess.exec("gem which cocoapods").wait(); | ||
| this.$childProcess.exec("gem which xcodeproj").wait(); |
There was a problem hiding this comment.
Do we need to check for xcodeproj? It is a dependency of cocoapods.
There was a problem hiding this comment.
We need this in order to ensure that this script will be executed correctly - https://github.com/NativeScript/nativescript-cli/blob/master/lib/services/ios-project-service.ts#L441
Fatme
pushed a commit
that referenced
this pull request
Oct 28, 2015
Check cocoapods availability before executing pod install
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.