Restructure error messaging #1057
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test PASSed. |
| @@ -14,6 +14,9 @@ fiber(() => { | |||
|
|
|||
| let commandDispatcher: ICommandDispatcher = $injector.resolve("commandDispatcher"); | |||
|
|
|||
| let messages = <IMessagesService>$injector.resolve("$messagesService"); | |||
There was a problem hiding this comment.
You may optionally use let messages: IMessagesService = $injector.resolve... for less code clutter.
Mitko-Kerezov
force-pushed
the
kerezov/restructure-error-messaging
branch
from
b5802cd to
bbb146c
Compare
|
Test FAILed. |
Mitko-Kerezov
force-pushed
the
kerezov/restructure-error-messaging
branch
from
bbb146c to
29995cb
Compare
|
Test PASSed. |
|
👍 |
added 2 commits
November 16, 2015 16:14
Makes use of JSON files containing string messages which can later be accessed from within the CLI. A dev command (dev-generate-messages) is introduced for ease of use and autocompletion. There is a default json message file with is loaded by default however each client may provide their own json file and thus override keys, extend and so on. Includes a bit of refactoring concerning swagger code generation - extracting/moving common interfaces/implementation classes to common.
Mitko-Kerezov
force-pushed
the
kerezov/restructure-error-messaging
branch
from
29995cb to
76ca606
Compare
|
Test PASSed. |
Mitko-Kerezov
added a commit
that referenced
this pull request
Nov 17, 2015
…messaging Restructure error messaging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detailed explanation can be found here: telerik/mobile-cli-lib#484