Use correct .apk name #1053
Merged
Use correct .apk name #1053
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test PASSed. |
|
💯 |
| @@ -39,7 +39,7 @@ class AndroidProjectService extends projectServiceBaseLib.PlatformProjectService | |||
| public get platformData(): IPlatformData { | |||
| if (!this._platformData) { | |||
| let projectRoot = path.join(this.$projectData.platformsDir, "android"); | |||
|
|
|||
| let packageName = this.getProjectNameFromId(this.$projectData.projectId); | |||
There was a problem hiding this comment.
You can use this.$projectData.projectId inside getProjectNameFromId function
|
👍 after addressing my small suggestion |
|
Test PASSed. |
Gradle uses the third part of the identifier for apk name. Currently we are checking for projectName (created from dir name). Check both of them when searching for apk. Fixes #1041
rosen-vladimirov
force-pushed
the
vladimirov/fix-no-apk
branch
from
65a4f82 to
c1d19fb
Compare
|
Test PASSed. |
rosen-vladimirov
added a commit
that referenced
this pull request
Oct 13, 2015
Use correct .apk name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gradle uses the third part of the identifier for apk name. Currently we are
checking for projectName (created from dir name). Check both of them when
searching for apk.
Fixes #1041