Skip to content

Fix deployment target altering in CocoaPods setup. #1015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 6, 2015

Conversation

e2l3n
Copy link
Contributor

@e2l3n e2l3n commented Oct 6, 2015

Fix incorrect deployment target altering on prepare phase. This is caused by CocoaPods prepare step when a plugin is being processed.
See issue: #1012
Other related issues: #944

Re-target #1013

@Fatme
Copy link
Contributor

Fatme commented Oct 6, 2015

👍 after fixing the lint error

@ns-bot
Copy link

ns-bot commented Oct 6, 2015

Test FAILed.

@vchimev
Copy link

vchimev commented Oct 6, 2015

👍

@vchimev
Copy link

vchimev commented Oct 6, 2015

run ci

@ns-bot
Copy link

ns-bot commented Oct 6, 2015

Test FAILed.

@e2l3n e2l3n force-pushed the tpopov/pods-deployment branch from bf209d1 to 88800eb Compare October 6, 2015 14:28
@e2l3n e2l3n force-pushed the tpopov/pods-deployment branch from 88800eb to b9332eb Compare October 6, 2015 14:31
@ns-bot
Copy link

ns-bot commented Oct 6, 2015

Test PASSed.

1 similar comment
@ns-bot
Copy link

ns-bot commented Oct 6, 2015

Test PASSed.

@dtopuzov
Copy link
Contributor

dtopuzov commented Oct 6, 2015

👍

e2l3n added a commit that referenced this pull request Oct 6, 2015
Fix deployment target altering in CocoaPods setup.
@e2l3n e2l3n merged commit 1fa9fbb into release Oct 6, 2015
@e2l3n e2l3n added 3 - Done and removed 0 - Open labels Oct 6, 2015
@dtopuzov dtopuzov removed the 3 - Done label Oct 20, 2015
@e2l3n e2l3n deleted the tpopov/pods-deployment branch November 18, 2015 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants