Create, prepare and build commands for iOS #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -5,4 +5,6 @@ export var DEFAULT_PROJECT_ID = "com.telerik.tns.HelloWorld"; | |||
| export var DEFAULT_PROJECT_NAME = "HelloNativescript"; | |||
| export var APP_RESOURCES_FOLDER_NAME = "App_Resources"; | |||
| export var PROJECT_FRAMEWORK_FOLDER_NAME = "framework"; | |||
| export var IOS_PROJECT_NAME_PLACEHOLDER = "__PROJECT_NAME__"; | |||
There was a problem hiding this comment.
Do we need those constants here? They can live in the iOS module because they are used only there.
| @@ -12,6 +12,8 @@ $injector.require("projectTemplatesService", "./services/project-templates-servi | |||
| $injector.require("platformsData", "./services/platform-service"); | |||
| $injector.require("platformService", "./services/platform-service"); | |||
|
|
|||
| $injector.require("versioningService", "./services/versioning-service"); | |||
|
Should be rebased on master. Also it is better to squash all those commits. |
|
@Fatme What about this one? #10 (comment) |
|
👍 |
Fatme
added a commit
that referenced
this pull request
Aug 8, 2014
Create, prepare and build commands for iOS
Fatme
pushed a commit
that referenced
this pull request
Nov 1, 2018
refactor() - [Yarn Support - Part 2] - Replace npm with package manag…
rigor789
pushed a commit
that referenced
this pull request
Feb 7, 2022
…l-sys-info-cache Add method to control the sys info cache
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.