Skip to content

"tns library add ios" does not build correct relative paths to referenced frameworks for mdgenerator #777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ginev opened this issue Aug 12, 2015 · 6 comments

Comments

@ginev
Copy link

ginev commented Aug 12, 2015

When using tns library add ios the added library is not correctly resolved by the metadata generator because it receives a faulty path to the referenced framework.

@ginev ginev added the bug label Aug 12, 2015
@Fatme Fatme added this to the 1.2.3 milestone Aug 13, 2015
@PanayotCankov
Copy link
Contributor

For iOS you should be able to open the Xcode project in platforms/ios and edit the framework search paths by hand to use absolute paths instead of relative paths.

@Fatme
Copy link
Contributor

Fatme commented Aug 14, 2015

This should be tested with latest ios-runtime from release branch.

@EddyVerbruggen
Copy link
Contributor

Just a heads-up: even with PR #266 applied locally it didn't resolve my framework. I had to add the full path instead, like documented here.

@maknz
Copy link

maknz commented Aug 17, 2015

I haven't tried the actual release, but using "\"$(PROJECT_DIR)/../../lib/iOS\"" in the pbxproj file manually doesn't solve the issue. In fact, now there's a build-time error of being unable to resolve the framework, instead of a runtime one where the constant is unavailable.

@Fatme
Copy link
Contributor

Fatme commented Aug 17, 2015

Hi @maknz,

You're right. Using "\"$(PROJECT_DIR)/../../lib/iOS\"" in the pbxproj file doesn't solve the issue. You need to fix the library output paths in {N} CLI as well. - https://github.com/NativeScript/nativescript-cli/pull/799/files

@EddyVerbruggen
Copy link
Contributor

Awesome! With 1.2.3 the barcodescanner plugin no longer needs manual steps to install thanks to this fix. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants