Skip to content

Enhance the merge of the native configuration files #592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 tasks
valentinstoychev opened this issue Jun 25, 2015 · 2 comments
Closed
2 tasks

Enhance the merge of the native configuration files #592

valentinstoychev opened this issue Jun 25, 2015 · 2 comments

Comments

@valentinstoychev
Copy link

There are two things we can do better with the merge of the plugin config for the native projects

  • Check if there are duplicate entries of the resulting merged configuration file and leave only one.
  • Merge not only on the root level, but also scan the sections and apply the changes in the configuration sections.

For example when you have this config snippet in the plugin AndroidManifest.xml:

<application>
   <meta-data android:name="com.google.android.gms.version"
    android:value="@integer/google_play_services_version" />

   <meta-data android:name="com.google.android.geo.API_KEY" android:value="AIzaSyCMjyff-PWVM9N5KCSZmXngbwZjBPZB-E8"/>
</application>

we should make sure that these declarations are merged into the existing <application> section of the native AndroidManifest.xml and not to create a second <application> section, which is later ignored by the Android runtime.

@PanayotCankov
Copy link
Contributor

I think we should allow the API key to be added to source control. node_modules are usually ignored from source control so the module files won't be suitable.

@ligaz
Copy link

ligaz commented Feb 26, 2016

This has been addressed with our Gradle support: #687

@ligaz ligaz closed this as completed Feb 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants