Skip to content

NativeScript Plugins support #510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
14 of 15 tasks
ligaz opened this issue May 31, 2015 · 2 comments
Closed
14 of 15 tasks

NativeScript Plugins support #510

ligaz opened this issue May 31, 2015 · 2 comments
Assignees
Labels

Comments

@ligaz
Copy link

ligaz commented May 31, 2015

This issue outlines the work breakdown for supporting NativeScript Plugins in the CLI

v1.1

Plugin commands

  • add - will support everything npm install supports. Will save the installed plugin in package.json. The plugin itself will be installed in node_modules.
  • remove - will remove the plugin. Basically npm uninstall ... --save with some other magic.
  • prepare - hidden command that will do all the required mumbo-jumbo to install a plugin. Actually adding a plugin will be decomposed to npm install followed by tns plugin prepare

Supported functionality

  • NPM based workflow.
  • require of JavaScript files from the plugin. prepare will ensure the script files are in the native platform tns_modules folder, so that they can be required. The package.json of the plugin should also be there in case there is a main declared.
  • Merging of native configuration files (AndroidManifest.xml and Info.plist)

v1.2

  • Ability to package native libraries and frameworks in the plugin.
    • Android
      • Respect Android libraries added to platforms/android
      • Respect jars added to platforms/android/libs
      • Remove the library when removing the plugin
    • iOS
      • Support for dynamic libraries (*.framework)

v1.3

v1.4

  • Support for static iOS libraries

v1.5

  • Ability to package resources (images, xml files declaring native UI, etc.) in the plugin.
  • Ability to define plugin variables (ex: API keys that should be defined per plugin installation)
@Fatme Fatme added the changelog label Jun 8, 2015
@Fatme Fatme added this to the 1.1.0 milestone Jun 8, 2015
@Fatme Fatme added the feature label Jun 12, 2015
@Fatme Fatme modified the milestones: 1.2.0, 1.1.0 Jun 22, 2015
@valentinstoychev
Copy link

related:
#592
#591

@Plamen5kov
Copy link
Contributor

I don't believe it's a good idea to:
Ability to package resources (images, xml files declaring native UI, etc.) in the plugin.
At least not directly. The preferred way is to have only an .aar file that includes all of the elements described above.

@rosen-vladimirov rosen-vladimirov modified the milestones: 2.0, 1.7.0 Mar 14, 2016
@rosen-vladimirov rosen-vladimirov modified the milestones: 2.1 (Under consideration), 2.0 Apr 18, 2016
@rosen-vladimirov rosen-vladimirov removed this from the 2.1 (Under consideration) milestone May 26, 2016
@enchev enchev closed this as completed May 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

8 participants