Skip to content

fix: hooks not being called #5729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 12, 2023
Merged

fix: hooks not being called #5729

merged 1 commit into from
Apr 12, 2023

Conversation

rigor789
Copy link
Member

closes NativeScript/nativescript-app-templates#227

PR Checklist

What is the current behavior?

The hooks service is initialized and caches the hooksDirectories, however in some cases this might be an empty array (ie. when creating a new project, and the service is initialized before the project files exist yet).

What is the new behavior?

We only cache when there's items in the hooksDirectories (since this means the projectDir was defined)

Fixes/Implements/Closes #[Issue Number].

@cla-bot cla-bot bot added the cla: yes label Apr 12, 2023
@rigor789 rigor789 merged commit c35673e into main Apr 12, 2023
@rigor789 rigor789 deleted the fix/hooks-not-called branch April 12, 2023 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant