unit testing for freshly created angular project is broken when import a package from node_modules #4244

ochemerys · 2018-12-20T16:34:54Z

Environment
$ tns doctor
✔ Getting environment information

No issues were detected.
✔ Your ANDROID_HOME environment variable is set and points to correct directory.
✔ Your adb from the Android SDK is correctly installed.
✔ The Android SDK is installed.
✔ A compatible Android SDK for compilation is found.
✔ Javac is installed and is configured properly.
✔ The Java Development Kit (JDK) is installed and is configured properly.
✔ Xcode is installed and is configured properly.
✔ xcodeproj is installed and is configured properly.
✔ CocoaPods are installed.
✔ CocoaPods update is not required.
✔ CocoaPods are configured properly.
✔ Your current CocoaPods version is newer than 1.0.0.
✔ Python installed and configured correctly.
✔ The Python 'six' package is found.
✔ Xcode version 10.1.0 satisfies minimum required version 9.
✔ Getting NativeScript components versions information...
✔ Component nativescript has 5.1.0 version and is up to date.
✔ Component tns-core-modules has 5.1.0 version and is up to date.
✔ Component tns-android has 5.1.0 version and is up to date.
✔ Component tns-ios has 5.1.0 version and is up to date.

karma.conf.js contains
// list of files / patterns to load in the browser
files: [
'src/tests/**/*.js'
],

the same issue on iOS and Android devices

Describe the bug
unit testing for freshly created angular project is broken when import a package from node_modules

To Reproduce
I followed steps for workarounds provided in #4232
then I added
import { expect } from 'chai';
my test fails with error message:

5 12 2018 15:02:23.006:WARN [NativeScript / 28 (9; Android SDK built for x86)]: Adapter did not report total number of specs.
NativeScript / 28 (9; Android SDK built for x86) ../../tests/example.spec.js at line 0 FAILED
Error: com.tns.NativeScriptException: Failed to find module: "chai", relative to: app/tns_modules/
com.tns.Module.resolvePathHelper(Module.java:146)
com.tns.Module.resolvePath(Module.java:55)
com.tns.Runtime.callJSMethodNative(Native Method)
com.tns.Runtime.dispatchCallJSMethodNative(Runtime.java:1120)
com.tns.Runtime.callJSMethodImpl(Runtime.java:1000)
com.tns.Runtime.callJSMethod(Runtime.java:987)
com.tns.Runtime.callJSMethod(Runtime.java:967)
com.tns.Runtime.callJSMethod(Runtime.java:959)
com.tns.gen.java.lang.Runnable.run(Runnable.java:15)
android.os.Handler.handleCallback(Handler.java:873)
android.os.Handler.dispatchMessage(Handler.java:99)
android.os.Looper.loop(Looper.java:193)
android.app.ActivityThread.main(ActivityThread.java:6669)
java.lang.reflect.Method.invoke(Native Method)
com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:493)
com.android.internal.os.ZygoteInit.main(ZygoteInit.java:858)
NativeScript / 28 (9; Android SDK built for x86): Executed 1 of null (1 FAILED) ERROR (0.056 secs / 0 secs)
Test run failed.

it looks like test runner is not able to find installed chai npm package

I commented out "chai" and tried "sinon" instead.
The same result

Expected behavior
I should be able to use import statements for node packages

Is there any workaround for this one?

The text was updated successfully, but these errors were encountered:

endarova · 2018-12-21T09:00:50Z

Hi @ochemerys ,
Thanks for reporting this issue. I was able to reproduce it too. We will have to investigate it.

…n tests page Rel to: NativeScript/nativescript-angular#1310 NativeScript/nativescript-cli#4244

Rel to: NativeScript/nativescript-angular#1310 #4244

Fatme · 2019-01-30T09:43:13Z

Hi @ochemerys,

Sorry for the late reply.

chai module is added as devDependency to your project. This is the reason why it is not included in the built package and the reason to see the following error Failed to find module: "chai", relative to: app/tns_modules/.

Actually you don't need to import the chai module. Karma runner cares to automatically inject the framework (in your case chai and mocha) into tests. This way the example test below works out of the box without any import.

// A sample Mocha test
describe('Array', function () {
	describe('#indexOf()', function () {
		it('should return -1 when the value is not present', function () {
			assert.equal(-1, [1,2,3].indexOf(5));
			assert.equal(-1, [1,2,3].indexOf(0));
		});
	});
});

We released a new version of the nativescript-unit-test-runner package where the issue with nsconfig file is fixed. (the workaround mentioned here #4232 (comment)).
In order to test it on your side, you need the following:

npm i nativescript-unit-test-runner

Let us know if it works for you.

dtopuzov · 2019-01-31T10:34:10Z

Fixed in [email protected]

ochemerys · 2019-02-02T19:58:13Z

Hi @Fatme
I added import chai just to see how test runner works with import statement
after running
npm i nativescript-unit-test-runner
test:

// A sample Mocha test
describe('Array', function () {
	describe('#indexOf()', function () {
		it('should return -1 when the value is not present', function () {
			chai.assert.equal(-1, [1,2,3].indexOf(5));
			chai.assert.equal(-1, [1,2,3].indexOf(0));
		});
	});
});

still fails for me with message

no reachable host

on android device emulator-5554

Fatme · 2019-02-02T20:16:06Z

@ochemerys,

Do you have android:usesCleartextTraffic=“true” in AndroidManifest.xml? It is mandatory for emulators with api level 28.

ochemerys · 2019-02-02T22:31:13Z

@Fatme
thank you, I added android:usesCleartextTraffic=“true” (just forgot to check if it is there) and now it works fine if there is no import statement
when i added import {appComponent} from '../app/app.component' it shows me no reachable hosts again.
After running tns platform clean android and tns test android it gives me

Adapter did not report total number of specs.

with

ReferenceError: exports is not defined

and Test run failed.

Fatme · 2019-02-03T07:03:07Z

@ochemerys,

 var ItemsComponent = require('../app/item/items.component');

ochemerys · 2019-02-03T16:10:17Z

@Fatme
Thank you,
I updated my code accordingly your suggestion.
After running tns platform clean android and tns test android test is successful
but when I modified code (var is replaced with const ) and saved i got a message
no reachable hosts
I returned back to var declaration and still the same until I run tns platform clean android

ochemerys · 2019-02-03T17:52:59Z

@Fatme
After running tns platform clean android
and my code

var AppComponent = require('../app/app.component');

// A sample Mocha test //
describe('Array', function () {
	describe('#indexOf()', function () {
		it('should return -1 when the value is not present', function () {
			chai.assert.equal(-1, [1,2,3].indexOf(5));
			chai.assert.equal(-1, [1,2,3].indexOf(0));
		});
	});
});

after
tns test android
fails with error :

03 02 2019 10:42:58.328:WARN [NativeScript / 28 (9; Android SDK built for x86)]: Adapter did not report total number of specs.
NativeScript / 28 (9; Android SDK built for x86)  /base/src/tests/example.spec.js?2200c3f5880411d7cf4a73aab7d0f13bc31cf409 at line 0 FAILED
        Error: com.tns.NativeScriptException: Failed to find module: "../app/app.component", relative to: app//
            com.tns.Module.resolvePathHelper(Module.java:146)
            com.tns.Module.resolvePath(Module.java:55)
            com.tns.Runtime.callJSMethodNative(Native Method)
            com.tns.Runtime.dispatchCallJSMethodNative(Runtime.java:1120)
            com.tns.Runtime.callJSMethodImpl(Runtime.java:1000)
            com.tns.Runtime.callJSMethod(Runtime.java:987)
            com.tns.Runtime.callJSMethod(Runtime.java:967)
            com.tns.Runtime.callJSMethod(Runtime.java:959)
            com.tns.gen.java.lang.Runnable.run(Runnable.java:15)
            android.os.Handler.handleCallback(Handler.java:873)
            android.os.Handler.dispatchMessage(Handler.java:99)
            android.os.Looper.loop(Looper.java:193)
            android.app.ActivityThread.main(ActivityThread.java:6669)
            java.lang.reflect.Method.invoke(Native Method)
            com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:493)
            com.android.internal.os.ZygoteInit.main(ZygoteInit.java:858)
NativeScript / 28 (9; Android SDK built for x86): Executed 1 of null (1 FAILED) ERROR (0.056 secs / 0 secs)
JS: NSUTR: completeAck
JS: NSUTR-socket.io: io server disconnect
Test run failed.

ochemerys · 2019-02-03T21:04:41Z

@Fatme
I have nativescript latest version on today
tns doctor returns

✔ Getting environment information

No issues were detected.
✔ Your ANDROID_HOME environment variable is set and points to correct directory.
✔ Your adb from the Android SDK is correctly installed.
✔ The Android SDK is installed.
✔ A compatible Android SDK for compilation is found.
✔ Javac is installed and is configured properly.
✔ The Java Development Kit (JDK) is installed and is configured properly.
✔ Xcode is installed and is configured properly.
✔ xcodeproj is installed and is configured properly.
✔ CocoaPods are installed.
✔ CocoaPods update is not required.
✔ CocoaPods are configured properly.
✔ Your current CocoaPods version is newer than 1.0.0.
✔ Python installed and configured correctly.
✔ The Python 'six' package is found.
✔ Xcode version 10.1.0 satisfies minimum required version 9.
✔ Getting NativeScript components versions information...
✔ Component nativescript has 5.1.1 version and is up to date.
✔ Component tns-core-modules has 5.1.2 version and is up to date.
✔ Component tns-android has 5.1.0 version and is up to date.
✔ Component tns-ios has 5.1.1 version and is up to date.

steps to reproduce

tns create tns-ng-mocha --template tns-template-hello-world-ng
cd tns-ng-mocha
npm install
tns test init and select mocha
add to AndroidManifest.xml

<application
	android:usesCleartextTraffic="true"

run tns test android test is success
remove example.js file and add example.spec.ts file into tests folder

var AppComponent = require('../app/app.component');

// A sample Mocha test //
describe('Array', function () {
	describe('#indexOf()', function () {
		it('should return -1 when the value is not present', function () {
			chai.assert.equal(-1, [1,2,3].indexOf(5));
			chai.assert.equal(-1, [1,2,3].indexOf(0));
		});
	});
});

run tns test android again and test fails with error:

JS: NSUTR: this.error: Error: com.tns.NativeScriptException: Failed to find module: "../app/app.component", relative to: app//
JS: com.tns.Module.resolvePathHelper(Module.java:146)
JS: com.tns.Module.resolvePath(Module.java:55)
JS: com.tns.Runtime.callJSMethodNative(Native Method)
JS: com.tns.Runtime.dispatchCallJSMethodNative(Runtime.java:1120)
JS: com.tns.Runtime.callJSMethodImpl(Runtime.java:1000)
JS: com.tns.Runtime.callJSMethod(Runtime.java:987)
JS: com.tns.Runtime.callJSMethod(Runtime.java:967)
JS: com.tns.Runtime.callJSMethod(Runtime.java:959)
JS: com.tns.gen.java.lang.Runnable.run(Runnable.java:15)
JS: android.os.Handler.handleCallback(Handler.java:873)
JS: android.os.Handler.dispatchMessage(Handler.java:99)
JS: android.os.Looper.loop(Looper.java:193)
JS: android.app.ActivityThread.main(ActivityThread.java:6669)
JS: java.lang.reflect.Method.invoke(Native Method)
JS: com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:493)
JS: com.android.internal.os.ZygoteInit.main(ZygoteInit.java...
JS: NSUTR: completed test run.
03 02 2019 13:36:01.957:WARN [NativeScript / 28 (9; Android SDK built for x86)]: Adapter did not report total number of specs.
NativeScript / 28 (9; Android SDK built for x86) /base/src/tests/example.spec.js?9d9673dccee7326a40481232a03ed59b331d3c28 at line 0 FAILED
Error: com.tns.NativeScriptException: Failed to find module: "../app/app.component", relative to: app//
com.tns.Module.resolvePathHelper(Module.java:146)
com.tns.Module.resolvePath(Module.java:55)
com.tns.Runtime.callJSMethodNative(Native Method)
com.tns.Runtime.dispatchCallJSMethodNative(Runtime.java:1120)
com.tns.Runtime.callJSMethodImpl(Runtime.java:1000)
com.tns.Runtime.callJSMethod(Runtime.java:987)
com.tns.Runtime.callJSMethod(Runtime.java:967)
com.tns.Runtime.callJSMethod(Runtime.java:959)
com.tns.gen.java.lang.Runnable.run(Runnable.java:15)
android.os.Handler.handleCallback(Handler.java:873)
android.os.Handler.dispatchMessage(Handler.java:99)
android.os.Looper.loop(Looper.java:193)
android.app.ActivityThread.main(ActivityThread.java:6669)
java.lang.reflect.Method.invoke(Native Method)
com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:493)
com.android.internal.os.ZygoteInit.main(ZygoteInit.java:858)
NativeScript / 28 (9; Android SDK built for x86): Executed 1 of null (1 FAILED) ERROR (0.049 secs / 0 secs)
JS: NSUTR: completeAck
03 02 2019 13:36:02.567:WARN [NativeScript / 28 (9; Android SDK built for x86)]: Disconnected (0 times)Client disconnected from CONNECTNativeScript / 28 (9; Android SDK built for x86) ERROR
DisconnectedClient disconnected from CONNECTED state (transport error)
NativeScript / 28 (9; Android SDK built for x86): Executed 1 of null (1 FAILED) ERROR (0.049 secs / 0 secs)
^CExecuting after-watch hook from /Users/olekschemerys/TRAINING/NativeScript/testing/tns-ng-mocha/hooks/after-watch/nativescript-dev-typescript.js
Stopping tsc watch
Executing after-watch hook from /Users/olekschemerys/TRAINING/NativeScript/testing/tns-ng-mocha/hooks/after-watch/nativescript-dev-webpack.js
Stopping webpack watch
Executing after-watch hook from /Users/olekschemerys/TRAINING/NativeScript/testing/tns-ng-mocha/hooks/after-watch/nativescript-dev-typescript.js
Executing after-watch hook from /Users/olekschemerys/TRAINING/NativeScript/testing/tns-ng-mocha/hooks/after-watch/nativescript-dev-webpack.js
Stopping webpack watch

Should I do something else to run tests?

Fatme · 2019-02-04T07:16:19Z

@ochemerys,

Component nativescript has 5.1.1 version and is up to date.

Can you please try with next version of nativescript

npm i -g nativescript@next

ochemerys · 2019-02-05T02:46:59Z

@Fatme
thank you
I run npm i -g nativescript@next and tns update next
test:

import { AppComponent }  from '../app/app.component';

// A sample Mocha test
describe('Array', function () {
	describe('#indexOf()', function () {
		it('should return -1 when the value is not present', function () {
			chai.assert.equal(-1, [1,2,3].indexOf(5));
			chai.assert.equal(-1, [1,2,3].indexOf(0));
		});
	});
});

now gives SUCCESS. Then I modified test to be sure that npm_modules are accessible:

import { expect } from 'chai';
import { AppComponent }  from '../app/app.component';

// A sample Mocha test
describe('Array', function () {
	describe('#indexOf()', function () {
		it('should return -1 when the value is not present', function () {
                         expect(true, "testing ...");
			// chai.assert.equal(-1, [1,2,3].indexOf(5));
			// chai.assert.equal(-1, [1,2,3].indexOf(0));
		});
	});
});

and test fails with error

JS: NSUTR: completed test run.
04 02 2019 19:42:34.086:WARN [NativeScript / 28 (9; Android SDK built for x86)]: Adapter did not report total number of specs.
NativeScript / 28 (9; Android SDK built for x86) ../../tests/example.spec.js at line 0 FAILED
Error: com.tns.NativeScriptException: Failed to find module: "chai", relative to: app/tns_modules/
com.tns.Module.resolvePathHelper(Module.java:146)
com.tns.Module.resolvePath(Module.java:55)
com.tns.Runtime.callJSMethodNative(Native Method)
com.tns.Runtime.dispatchCallJSMethodNative(Runtime.java:1203)
com.tns.Runtime.callJSMethodImpl(Runtime.java:1083)
com.tns.Runtime.callJSMethod(Runtime.java:1070)
com.tns.Runtime.callJSMethod(Runtime.java:1050)
com.tns.Runtime.callJSMethod(Runtime.java:1042)
com.tns.gen.java.lang.Runnable.run(Runnable.java:15)
android.os.Handler.handleCallback(Handler.java:873)
android.os.Handler.dispatchMessage(Handler.java:99)
android.os.Looper.loop(Looper.java:193)
android.app.ActivityThread.main(ActivityThread.java:6669)
java.lang.reflect.Method.invoke(Native Method)
com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:493)
com.android.internal.os.ZygoteInit.main(ZygoteInit.java:858)
NativeScript / 28 (9; Android SDK built for x86): Executed 1 of null (1 FAILED) ERROR (0.05 secs / 0 secs)
JS: NSUTR: completeAck
04 02 2019 19:42:34.707:WARN [NativeScript / 28 (9; Android SDK built for x86)]: Disconnected (0 times)Client disconnected from CONNECTNativeScript / 28 (9; Android SDK built for x86) ERROR
DisconnectedClient disconnected from CONNECTED state (transport error)
NativeScript / 28 (9; Android SDK built for x86): Executed 1 of null (1 FAILED) ERROR (0.05 secs / 0 secs)

Fatme · 2019-02-05T06:21:19Z

@ochemerys,

chai package is added as devDependency to your project. This means that NativeScript CLI will NOT prepare it and it will NOT be included in the built package. So this means that chai package will not be transferred to your device or emulator which means that the error Failed to find module: "chai", relative to: app/tns_modules/ in runtime is expected.

If you want to test some import from node_modules, you need to use some package that is dependency of your project, not devDependency.

NOTE: NativeScript CLI prepares only packages that are dependencies of your project. devDependencies are not prepared and are not included in the built package.

ochemerys · 2019-02-06T01:56:20Z

@Fatme
Thank you very much for clarification
I installed nativescript-toast package, imported it to my test and ran the test. Test was successful.
Thanks.

ochemerys changed the title ~~unit testing for freshly created angular project is broken when import a package from node_modulesmodule~~ unit testing for freshly created angular project is broken when import a package from node_modules Dec 21, 2018

endarova added the bug label Dec 21, 2018

endarova added the unit testing label Dec 21, 2018

ochemerys mentioned this issue Jan 10, 2019

unit testing for freshly created angular project is broken on android simulator #4232

Closed

rosen-vladimirov added the severity: high label Jan 14, 2019

rosen-vladimirov added this to the 5.2.0 milestone Jan 14, 2019

rosen-vladimirov assigned Fatme Jan 14, 2019

Fatme added the in progress label Jan 19, 2019

Fatme added a commit to NativeScript/nativescript-unit-test-runner that referenced this issue Jan 21, 2019

feat: respect nsconfig file from project and correctly navigate to ru…

ed742f9

…n tests page Rel to: NativeScript/nativescript-angular#1310 NativeScript/nativescript-cli#4244

Fatme mentioned this issue Jan 21, 2019

feat: respect nsconfig file from project and correctly navigate to run tests page NativeScript/nativescript-unit-test-runner#28

Merged

Fatme added a commit to NativeScript/nativescript-unit-test-runner that referenced this issue Jan 21, 2019

feat: respect nsconfig file from project and correctly navigate to ru…

402448a

…n tests page Rel to: NativeScript/nativescript-angular#1310 NativeScript/nativescript-cli#4244

Fatme added a commit that referenced this issue Jan 21, 2019

fix: respect nsconfig file on tns test command

87bc3df

Rel to: NativeScript/nativescript-angular#1310 #4244

Fatme mentioned this issue Jan 21, 2019

fix: respect nsconfig file on tns test command #4306

Merged

5 tasks

Fatme added ready for test and removed in progress labels Jan 30, 2019

dtopuzov self-assigned this Jan 31, 2019

dtopuzov closed this as completed Jan 31, 2019

dtopuzov removed the ready for test label Jan 31, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

unit testing for freshly created angular project is broken when import a package from node_modules #4244

unit testing for freshly created angular project is broken when import a package from node_modules #4244

ochemerys commented Dec 20, 2018 •

edited

Loading

endarova commented Dec 21, 2018

Fatme commented Jan 30, 2019

dtopuzov commented Jan 31, 2019

ochemerys commented Feb 2, 2019

Fatme commented Feb 2, 2019

ochemerys commented Feb 2, 2019

Fatme commented Feb 3, 2019

ochemerys commented Feb 3, 2019

ochemerys commented Feb 3, 2019

ochemerys commented Feb 3, 2019

Fatme commented Feb 4, 2019

ochemerys commented Feb 5, 2019

Fatme commented Feb 5, 2019

ochemerys commented Feb 6, 2019

unit testing for freshly created angular project is broken when import a package from node_modules #4244

unit testing for freshly created angular project is broken when import a package from node_modules #4244

Comments

ochemerys commented Dec 20, 2018 • edited Loading

endarova commented Dec 21, 2018

Fatme commented Jan 30, 2019

dtopuzov commented Jan 31, 2019

ochemerys commented Feb 2, 2019

Fatme commented Feb 2, 2019

ochemerys commented Feb 2, 2019

Fatme commented Feb 3, 2019

ochemerys commented Feb 3, 2019

ochemerys commented Feb 3, 2019

ochemerys commented Feb 3, 2019

steps to reproduce

Fatme commented Feb 4, 2019

ochemerys commented Feb 5, 2019

Fatme commented Feb 5, 2019

ochemerys commented Feb 6, 2019

ochemerys commented Dec 20, 2018 •

edited

Loading