Skip to content

Many - "file change detected. Starting incremental compilation.... " #3687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
RoyiNamir opened this issue Jun 17, 2018 · 5 comments
Closed

Many - "file change detected. Starting incremental compilation.... " #3687

RoyiNamir opened this issue Jun 17, 2018 · 5 comments
Assignees
@Fatme
Labels
bug

Comments

@RoyiNamir
Copy link

RoyiNamir commented Jun 17, 2018 •
edited
Loading

Using the latest version ( 4.1 & Angular 6 , on Windows 10 , webpack 0.13) -

tns create aaa --ng
npm install --save-dev nativescript-dev-webpack
npm install
tns run android

Is causing many repeated messages :

image

(finally succeeding).
Fatme added a commit to NativeScript/nativescript-dev-typescript that referenced this issue Jun 18, 2018
@Fatme
Fix many 'file change detected' messages
660295b 
Fixes NativeScript/nativescript-cli#3687

When `tns run android` command is executed, a typescript watcher is started. When project is prepared {N} CLI moves all files in platforms directory. This triggers a typescript watcher to print `File change detected. Starting incremental compilation...` message many times. This PR hides all messages from typescript compiler except errors. So the user will see only typescript errors. Actually when the command is executed with --log trace option, all messages from typescript compiler will be printed.
@Fatme Fatme mentioned this issue Jun 18, 2018
Merged
4 tasks
@Fatme
Copy link
Contributor

Fatme commented Jun 18, 2018

Hi @RoyiNamir,

Thank you for reporting this issue.

We've investigated the problem and fixed it. The fix will be released in next version of nativescript-dev-typescript plugin. I'll update you here in this thread when the fix is live.

@RoyiNamir
Copy link
Author

RoyiNamir commented Jun 18, 2018 •
edited
Loading

@Fatme Thank you for your quick response. Can you please reference the change in code ?

@albertobastos
Copy link

Probably related with #3547, will confirm after the next release including the fix is launched.

@Fatme Fatme reopened this Jun 22, 2018
@Fatme
Copy link
Contributor

Fatme commented Jun 22, 2018

Hi @RoyiNamir,

Sorry for late reply. The change is inside nativescript-dev-typescript plugin. You can see it here https://github.com/NativeScript/nativescript-dev-typescript/pull/55/files.

@miroslavaivanova miroslavaivanova self-assigned this Jun 22, 2018
@miroslavaivanova miroslavaivanova removed their assignment Jun 22, 2018
@RoyiNamir
Copy link
Author

@Fatme @miroslavaivanova Hi.
Should this ^ be moved to https://github.com/NativeScript/nativescript-dev-typescript ?
(jsut asking)

@RoyiNamir RoyiNamir mentioned this issue Aug 10, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Fatme Fatme

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@Fatme @RoyiNamir @miroslavaivanova @albertobastos @rosen-vladimirov