Skip to content

Once snapshot is added to android build user cannot build without it #3335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ndinev opened this issue Jan 24, 2018 · 0 comments · Fixed by NativeScript/nativescript-dev-webpack#423
Closed

Once snapshot is added to android build user cannot build without it #3335

ndinev opened this issue Jan 24, 2018 · 0 comments · Fixed by NativeScript/nativescript-dev-webpack#423
Assignees
@Mitko-Kerezov
Labels
bug
Milestone
4.0.0

Comments

@ndinev
Copy link

ndinev commented Jan 24, 2018

tns version is 3.4.1

When once snapshot is added to android build it will always be included in the pack with the next builds even user do not want it.

To reproduce the problem just build first with snapshot
tns build android --bundle --env.snapshot

and then build without snaphot
tns build android --bundle
Look in the result .apk file - snapshot is added, but shouldn'tt
@dtopuzov dtopuzov added the bug label Jan 24, 2018
@rosen-vladimirov rosen-vladimirov self-assigned this Jan 24, 2018
Mitko-Kerezov pushed a commit to NativeScript/nativescript-dev-webpack that referenced this issue Jan 26, 2018
feat(build): clean snapshot artifacts on cleanApp hook
874773e 
This fixes NativeScript/nativescript-cli#3335
@Mitko-Kerezov Mitko-Kerezov mentioned this issue Jan 26, 2018
Merged
@Natalia-Hristova Natalia-Hristova added this to the 3.4.2 milestone Jan 31, 2018
Mitko-Kerezov pushed a commit to NativeScript/nativescript-dev-webpack that referenced this issue Feb 14, 2018
feat(build): clean snapshot artifacts on cleanApp hook
b9b645f 
This fixes NativeScript/nativescript-cli#3335
sis0k0 pushed a commit to NativeScript/nativescript-dev-webpack that referenced this issue Feb 15, 2018
@Mitko-Kerezov @sis0k0
fix: clean snapshot artifacts on cleanApp hook (#423)
50c3ab9 
This fixes NativeScript/nativescript-cli#3335
@rosen-vladimirov rosen-vladimirov modified the milestones: 3.4.2, 4.0.0 Feb 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Mitko-Kerezov Mitko-Kerezov

Labels
bug
Projects
None yet
Milestone
4.0.0
Development

Successfully merging a pull request may close this issue.

fix: clean snapshot artifacts on cleanApp hook NativeScript/nativescript-dev-webpack
6 participants
@ndinev @miroslavaivanova @Natalia-Hristova @dtopuzov @Mitko-Kerezov @rosen-vladimirov