Skip to content

node-package-manager assumes that platform package is always the first in the list of updated ones #3217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
buuhuu opened this issue Nov 13, 2017 · 3 comments
Assignees
Labels
Milestone

Comments

@buuhuu
Copy link

buuhuu commented Nov 13, 2017

In node-package-manager.ts#L158 the assumption is made that the installed platform package is always the first entry in the list of returned updated dependencies. In my setup I install a couple of file:... dependencies which are listed in the same place:

[
  {
    "action": "update",
    "name": "nativescript-adobe-marketing-cloud",
    "version": "file:nativescript-adobe-marketing-cloud-1.3.1.tgz",
    "path": "...",
    "previousVersion": ""
  },
  {
    "action": "update",
    "name": "nativescript-angular",
    "version": "file:nativescript-angular-3.1.3.tgz",
    "path": "...",
    "previousVersion": ""
  },
  {
    "action": "update",
    "name": "nativescript-google-maps-sdk",
    "version": "file:nativescript-google-maps-sdk-2.3.1.tgz",
    "path": "...",
    "previousVersion": ""
  },
  {
    "action": "update",
    "name": "nativescript-image-swipe",
    "version": "file:nativescript-image-swipe-2.0.3.tgz",
    "path": "...",
    "previousVersion": ""
  },
  {
    "action": "update",
    "name": "tns-android",
    "version": "3.1.1",
    "path": "...",
    "previousVersion": "3.1.1"
  }
]

And tns-android in that case it the last entry.

@rosen-vladimirov
Copy link
Contributor

Hey @buuhuu ,
Can you send us the output of the following commands:

$ node -v
$ npm -v 

@rosen-vladimirov
Copy link
Contributor

Also which command fails on your side? Is it tns build android or something else?

@buuhuu
Copy link
Author

buuhuu commented Nov 13, 2017

node 8.9.1, npm 5.5.1 and it is tns prepare android and any other like that - working on a PR right now.

buuhuu pushed a commit to buuhuu/nativescript-cli that referenced this issue Nov 13, 2017
@buuhuu buuhuu changed the title node-package-manager that platform package is always the first in the list of updated ones node-package-manager assumes that platform package is always the first in the list of updated ones Nov 13, 2017
@rosen-vladimirov rosen-vladimirov self-assigned this Nov 15, 2017
@rosen-vladimirov rosen-vladimirov added this to the 3.3.1 milestone Nov 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants