Skip to content

nativescript-unit-test-runner is included in release build #2773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dtopuzov opened this issue May 4, 2017 · 4 comments
Closed

nativescript-unit-test-runner is included in release build #2773

dtopuzov opened this issue May 4, 2017 · 4 comments

Comments

@dtopuzov
Copy link
Contributor

dtopuzov commented May 4, 2017

From @enchev on June 9, 2016 14:54

From @rosen-vladimirov on March 7, 2016 7:27

In case the application has dependency on nativescript-unit-test-runner, calling tns build <platform> --release will include the unit-test runner in the prepared package. It is not expected to have it there in release build.

Some options to resolve the issue:

  • Implement special logic in CLI to exclude the nativescript-unit-test-runner when in release build. The problem here is that if the same issue occurs with other modules, we'll have to hard-code them in CLI as well.
  • Install nativescript-unit-test-runner as devDependency and add logic in it to be copied to <platforms> directory on after-prepare. This way the plugin will have the logic when to be copied to the project and when not. The same approach can be used for other packages.

Copied from original issue: #1572

Copied from original issue: NativeScript/nativescript-unit-test-runner#11

@dtopuzov
Copy link
Contributor Author

dtopuzov commented May 4, 2017

From @enchev on June 9, 2016 14:54

From @dtopuzov on June 6, 2016 12:22

Still valid in {N} 2.0.1

@dtopuzov
Copy link
Contributor Author

dtopuzov commented May 4, 2017

From @enchev on June 9, 2016 14:54

In my opinion it will be better if we implement the logic in the plugin itself (second option). I'm moving this issue to the nativescript-unit-test-runner repo.

@dtopuzov
Copy link
Contributor Author

dtopuzov commented May 4, 2017

Still valid in {N} 2.2.1

@dtopuzov
Copy link
Contributor Author

dtopuzov commented May 4, 2017

This problem is not nativescript-unit-test-runner, it is generic CLI feature that is currently missing (#2776).

@dtopuzov dtopuzov closed this as completed May 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant