Skip to content

nativescript-unit-test-runner is included in release build #1572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rosen-vladimirov opened this issue Mar 7, 2016 · 3 comments
Closed

nativescript-unit-test-runner is included in release build #1572

rosen-vladimirov opened this issue Mar 7, 2016 · 3 comments

Comments

@rosen-vladimirov
Copy link
Contributor

In case the application has dependency on nativescript-unit-test-runner, calling tns build <platform> --release will include the unit-test runner in the prepared package. It is not expected to have it there in release build.

Some options to resolve the issue:

  • Implement special logic in CLI to exclude the nativescript-unit-test-runner when in release build. The problem here is that if the same issue occurs with other modules, we'll have to hard-code them in CLI as well.
  • Install nativescript-unit-test-runner as devDependency and add logic in it to be copied to <platforms> directory on after-prepare. This way the plugin will have the logic when to be copied to the project and when not. The same approach can be used for other packages.
@dtopuzov
Copy link
Contributor

dtopuzov commented Jun 6, 2016

Still valid in {N} 2.0.1

@enchev enchev removed this from the 2.1 milestone Jun 6, 2016
@enchev
Copy link
Contributor

enchev commented Jun 9, 2016

In my opinion it will be better if we implement the logic in the plugin itself (second option). I'm moving this issue to the nativescript-unit-test-runner repo.

@enchev
Copy link
Contributor

enchev commented Jun 9, 2016

This issue was moved to NativeScript/nativescript-unit-test-runner#11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants