Skip to content

[2.5.0] Livesync watches .DS_Store files #2472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
roblav96 opened this issue Feb 1, 2017 · 4 comments
Closed

[2.5.0] Livesync watches .DS_Store files #2472

roblav96 opened this issue Feb 1, 2017 · 4 comments
Assignees
@rosen-vladimirov
Milestone
2.5.1

Comments

@roblav96
Copy link
Contributor

roblav96 commented Feb 1, 2017 •
edited
Loading

Steps to reproduce

  • tns livesync ios --watch
  • change a file
  • cli applies changes
  • ~1 second later transfers .DS_Store files rebooting app

Console

Executing before-prepare hook from /Users/roblav96/Projects/app-smile/ghmobile/hooks/before-prepare/nativescript-dev-typescript.js
Preparing project...
Project successfully prepared (ios)
Transferring project files...
Successfully transferred .DS_Store.
Successfully transferred .DS_Store.
Refreshing application...

tns info

┌──────────────────┬─────────────────┬────────────────┬─────────────┐
│ Component        │ Current version │ Latest version │ Information │
│ nativescript     │ 2.5.0           │ 2.5.0          │ Up to date  │
│ tns-core-modules │ 2.5.0           │ 2.5.0          │ Up to date  │
│ tns-android      │ 2.5.0           │ 2.5.0          │ Up to date  │
│ tns-ios          │ 2.5.0           │ 2.5.0          │ Up to date  │
└──────────────────┴─────────────────┴────────────────┴─────────────┘

A bit of a show stopper since making one file change reboots the app 3 or more times.

v2.4.2 does not have this issue.

PR

#2473
roblav96 added a commit to roblav96/nativescript-cli that referenced this issue Feb 1, 2017
@roblav96
Ignore .DS_Store file changes on Mac
f463ca0 
### chokidar#path-filtering
https://github.com/paulmillr/chokidar#path-filtering

Resolves:
NativeScript#2472
@roblav96 roblav96 mentioned this issue Feb 1, 2017
Merged
@vchimev vchimev added this to the 2.5.1 milestone Feb 2, 2017
@roblav96
Copy link
Contributor Author

roblav96 commented Feb 2, 2017

@rosen-vladimirov @vchimev how can i help with this? i would ❤️ to contribute.

@rosen-vladimirov
Copy link
Contributor

@roblav96 thank you very much. I think your PR was on the right direction. Can you try modifying the pattern, for example ignored: **/*.DS_Store and see if it will work on your side?

@roblav96
Copy link
Contributor Author

roblav96 commented Feb 2, 2017

@rosen-vladimirov I can confirm that ignored: '**/*.DS_Store' does indeed resolve the issue. I'll fix this in the PR. 😄

rosen-vladimirov pushed a commit that referenced this issue Feb 16, 2017
@roblav96 @rosen-vladimirov
Ignore .DS_Store file changes on Mac (#2473)
7003de6 
* Ignore .DS_Store file changes on Mac

https://github.com/paulmillr/chokidar#path-filtering

Resolves:
#2472

* Updated to ignored: '**/*.DS_Store'
@rosen-vladimirov rosen-vladimirov mentioned this issue Feb 16, 2017
Merged
rosen-vladimirov added a commit that referenced this issue Feb 16, 2017
@rosen-vladimirov
Ignore .DS_Store file changes on Mac (#2473) (#2551)
2fb92c4 
* Ignore .DS_Store file changes on Mac

https://github.com/paulmillr/chokidar#path-filtering

Resolves:
#2472

* Updated to ignored: '**/*.DS_Store'
@yalva
Copy link

yalva commented Jun 26, 2018

Is this part of latest nativescript-dev-webpack ?

with version 0.14.1 when I use --bundle webpack is watching for .DS_store file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rosen-vladimirov rosen-vladimirov

Labels
None yet
Projects
None yet
Milestone
2.5.1
Development

No branches or pull requests
4 participants
@roblav96 @rosen-vladimirov @vchimev @yalva