Skip to content

Out of the box support for application id in plugins #1026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Fatme opened this issue Oct 8, 2015 · 0 comments
Closed

Out of the box support for application id in plugins #1026

Fatme opened this issue Oct 8, 2015 · 0 comments
Milestone

Comments

@Fatme
Copy link
Contributor

Fatme commented Oct 8, 2015

We have a plugin that needs the app's id.

Currently its manifest contains something like:

<Manifest>
    <Service id="SERVICE_NAME" />
</Manifest>

Registering an intent service exposed through JavaScript API.

If the service name is provided as plug-in variable, the app package.json will look like:

{
    "nativescript": {
        "id": "com.nativescript.MyPlayground",
        "UploadPlugin": {
            "SERVICE_NAME": "com.nativescript.MyPlayground.UploadPluginService"
        }
    }
}

Currently the plug-in is so designed that the service name is always expected to be the app id suffixed with the plugin name. It would be nice if we could simply use an expression like {{nativescript.id}}.UploadPluginService in the plug-in's manifest.

@Fatme Fatme added this to the 1.4.2 milestone Oct 8, 2015
@Fatme Fatme mentioned this issue Oct 8, 2015
@Fatme Fatme modified the milestones: 1.4.1, 1.4.2 Oct 9, 2015
@Fatme Fatme modified the milestones: 1.4.2, 1.4.1 Oct 13, 2015
@teobugslayer teobugslayer modified the milestones: 1.5.0, 1.4.2 Oct 14, 2015
@dtopuzov dtopuzov modified the milestones: 1.6.0 (Under consideration), 1.5.0 Nov 11, 2015
Fatme pushed a commit that referenced this issue Jan 19, 2016
Removes the unneeded logic that merges configuration files
@ligaz ligaz closed this as completed Feb 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants