Fix execution of livesync hooks when there are no node_modules

In case `node_modules` are deleted from the project and `tns run <platform>` or `tns debug <platform>` is executed, the livesync hook fails as the package that's required in it is not installed.
In order to fix this, extract the logic of the liveSync method in a separate method and decorate it with the hook. In the public method make sure all dependencies are installed and call the private method.
This way the hook will be executed correctly.

Author: rosen-vladimirov

lib/services/livesync/debug-livesync-service.ts

@@ -12,6 +12,7 @@ export class DebugLiveSyncService extends LiveSyncService implements IDebugLiveS
 		protected $logger: ILogger,
 		$processService: IProcessService,
 		$hooksService: IHooksService,
+		$pluginsService: IPluginsService,
 		protected $injector: IInjector,
 		private $options: IOptions,
 		private $debugDataService: IDebugDataService,
@@ -28,6 +29,7 @@ export class DebugLiveSyncService extends LiveSyncService implements IDebugLiveS
 			$logger,
 			$processService,
 			$hooksService,
+			$pluginsService,
 			$injector);
 	}
 

lib/services/livesync/livesync-service.ts

@@ -28,28 +28,16 @@ export class LiveSyncService extends EventEmitter implements ILiveSyncService {
 		protected $logger: ILogger,
 		private $processService: IProcessService,
 		private $hooksService: IHooksService,
+		private $pluginsService: IPluginsService,
 		protected $injector: IInjector) {
 		super();
 	}
 
-	@hook("liveSync")
 	public async liveSync(deviceDescriptors: ILiveSyncDeviceInfo[],
 		liveSyncData: ILiveSyncInfo): Promise<void> {
 		const projectData = this.$projectDataService.getProjectData(liveSyncData.projectDir);
-		// In case liveSync is called for a second time for the same projectDir.
-		const isAlreadyLiveSyncing = this.liveSyncProcessesInfo[projectData.projectDir] && !this.liveSyncProcessesInfo[projectData.projectDir].isStopped;
-		this.setLiveSyncProcessInfo(liveSyncData.projectDir, deviceDescriptors);
-
-		const deviceDescriptorsForInitialSync = isAlreadyLiveSyncing ? _.differenceBy(deviceDescriptors, this.liveSyncProcessesInfo[projectData.projectDir].deviceDescriptors, deviceDescriptorPrimaryKey) : deviceDescriptors;
-
-		await this.initialSync(projectData, deviceDescriptorsForInitialSync, liveSyncData);
-
-		if (!liveSyncData.skipWatcher && deviceDescriptors && deviceDescriptors.length) {
-			// Should be set after prepare
-			this.$injector.resolve<DeprecatedUsbLiveSyncService>("usbLiveSyncService").isInitialized = true;
-
-			await this.startWatcher(projectData, liveSyncData);
-		}
+		await this.$pluginsService.ensureAllDependenciesAreInstalled(projectData);
+		await this.liveSyncOperation(deviceDescriptors, liveSyncData, projectData);
 	}
 
 	public async stopLiveSync(projectDir: string, deviceIdentifiers?: string[]): Promise<void> {
@@ -125,6 +113,25 @@ export class LiveSyncService extends EventEmitter implements ILiveSyncService {
 		this.$logger.info(`Successfully synced application ${liveSyncResultInfo.deviceAppData.appIdentifier} on device ${liveSyncResultInfo.deviceAppData.device.deviceInfo.identifier}.`);
 	}
 
+	@hook("liveSync")
+	private async liveSyncOperation(deviceDescriptors: ILiveSyncDeviceInfo[],
+		liveSyncData: ILiveSyncInfo, projectData: IProjectData): Promise<void> {
+		// In case liveSync is called for a second time for the same projectDir.
+		const isAlreadyLiveSyncing = this.liveSyncProcessesInfo[projectData.projectDir] && !this.liveSyncProcessesInfo[projectData.projectDir].isStopped;
+		this.setLiveSyncProcessInfo(liveSyncData.projectDir, deviceDescriptors);
+
+		const deviceDescriptorsForInitialSync = isAlreadyLiveSyncing ? _.differenceBy(deviceDescriptors, this.liveSyncProcessesInfo[projectData.projectDir].deviceDescriptors, deviceDescriptorPrimaryKey) : deviceDescriptors;
+
+		await this.initialSync(projectData, deviceDescriptorsForInitialSync, liveSyncData);
+
+		if (!liveSyncData.skipWatcher && deviceDescriptors && deviceDescriptors.length) {
+			// Should be set after prepare
+			this.$injector.resolve<DeprecatedUsbLiveSyncService>("usbLiveSyncService").isInitialized = true;
+
+			await this.startWatcher(projectData, liveSyncData);
+		}
+	}
+
 	private setLiveSyncProcessInfo(projectDir: string, deviceDescriptors: ILiveSyncDeviceInfo[]): void {
 		this.liveSyncProcessesInfo[projectDir] = this.liveSyncProcessesInfo[projectDir] || Object.create(null);
 		this.liveSyncProcessesInfo[projectDir].actionsChain = this.liveSyncProcessesInfo[projectDir].actionsChain || Promise.resolve();