Skip to content

Commit 7e8c9e2

Browse files
Fix unable to uninstall application on macOS
Update ios-device-lib where a fix for uninstalling application on macOS was not working. Update common lib where the following fixes are applied: * Fix `tns devices` not showing attached iOS devices. * Do not call uninstall of application when it is not installed - this produces some confusing warnings.
1 parent 67a2516 commit 7e8c9e2

File tree

4 files changed

+9
-6
lines changed

4 files changed

+9
-6
lines changed

lib/commands/debug.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ export class DebugIOSCommand extends DebugPlatformCommand {
118118
$projectData: IProjectData,
119119
$platformsData: IPlatformsData,
120120
$iosDeviceOperations: IIOSDeviceOperations,
121-
$debugLiveSyncService: IDebugLiveSyncService, ) {
121+
$debugLiveSyncService: IDebugLiveSyncService) {
122122
super($iOSDebugService, $devicesService, $debugDataService, $platformService, $projectData, $options, $platformsData, $logger,
123123
$errors, $debugLiveSyncService, $config);
124124
// Do not dispose ios-device-lib, so the process will remain alive and the debug application (NativeScript Inspector or Chrome DevTools) will be able to connect to the socket.

lib/commands/prepare.ts

+6-3
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,12 @@ export class PrepareCommand implements ICommand {
1717
public async canExecute(args: string[]): Promise<boolean> {
1818
const platform = args[0];
1919
const result = await this.$platformCommandParameter.validate(platform) && await this.$platformService.validateOptions(this.$options.provision, this.$projectData, platform);
20-
const platformData = this.$platformsData.getPlatformData(platform, this.$projectData);
21-
const platformProjectService = platformData.platformProjectService;
22-
await platformProjectService.validate(this.$projectData);
20+
if (!result) {
21+
const platformData = this.$platformsData.getPlatformData(platform, this.$projectData);
22+
const platformProjectService = platformData.platformProjectService;
23+
await platformProjectService.validate(this.$projectData);
24+
}
25+
2326
return result;
2427
}
2528
}

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@
4242
"glob": "^7.0.3",
4343
"iconv-lite": "0.4.11",
4444
"inquirer": "0.9.0",
45-
"ios-device-lib": "0.4.5",
45+
"ios-device-lib": "0.4.6",
4646
"ios-mobileprovision-finder": "1.0.9",
4747
"ios-sim-portable": "~3.0.0",
4848
"lockfile": "1.0.1",

0 commit comments

Comments
 (0)