Skip to content

Commit bb0a216

Browse files
committed
fix: fix PR comments
1 parent fab55aa commit bb0a216

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

lib/controllers/migrate-controller.ts

+4-4
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,11 @@ import { fromWindowsRelativePathToUnix } from "../common/helpers";
77

88
export class MigrateController extends UpdateControllerBase implements IMigrateController {
99
// TODO: Update the links to blog post when it is available
10+
private static COMMON_MIGRATE_MESSAGE = "not affect the codebase of the application and you might need to do additional changes manually – for more information, refer to the instructions in the following blog post: <link to blog post>.";
1011
private static UNABLE_TO_MIGRATE_APP_ERROR = `The current application is not compatible with NativeScript CLI 6.0.
1112
Use the \`tns migrate\` command to migrate the app dependencies to a form compatible with NativeScript 6.0.
12-
Running this command will not affect the codebase of the application and you might need to do additional changes manually –
13-
for more information, refer to the instructions in the following blog post: <link to blog post>.`;
14-
private static MIGRATE_FINISH_MESSAGE = "The `tns migrate` command does not affect the codebase of the application and you might need to do additional changes manually – for more information, refer to the instructions in the following blog post: <link to blog post>.";
13+
Running this command will ${MigrateController.COMMON_MIGRATE_MESSAGE}`;
14+
private static MIGRATE_FINISH_MESSAGE = `The \`tns migrate\` command does ${MigrateController.COMMON_MIGRATE_MESSAGE}`;
1515

1616
constructor(
1717
protected $fs: IFileSystem,
@@ -390,7 +390,7 @@ for more information, refer to the instructions in the following blog post: <lin
390390

391391
// Dependencies to migrate
392392
const dependencies = [
393-
{ packageName: "karma-webpack", verifiedVersion: "3.0.5", isDev: true, shouldAddIfMissing: !this.hasDependency({ packageName: "karma-webpack", isDev: true }, projectData) },
393+
{ packageName: "karma-webpack", verifiedVersion: "3.0.5", isDev: true, shouldAddIfMissing: true },
394394
{ packageName: "karma-jasmine", verifiedVersion: "2.0.1", isDev: true },
395395
{ packageName: "karma-mocha", verifiedVersion: "1.3.0", isDev: true },
396396
{ packageName: "karma-chai", verifiedVersion: "0.1.0", isDev: true },

0 commit comments

Comments
 (0)