Skip to content

Commit fab55aa

Browse files
committed
fix: check runtimeVersion only when the project has runtime property in package.json (tns-android or tns-ios)
1 parent 979321d commit fab55aa

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

lib/controllers/migrate-controller.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -160,7 +160,7 @@ for more information, refer to the instructions in the following blog post: <lin
160160

161161
for (const platform in this.$devicePlatformsConstants) {
162162
const hasRuntimeDependency = this.hasRuntimeDependency({ platform, projectData });
163-
if (!hasRuntimeDependency || await this.shouldUpdateRuntimeVersion({ targetVersion: this.verifiedPlatformVersions[platform.toLowerCase()], platform, projectData })) {
163+
if (hasRuntimeDependency && await this.shouldUpdateRuntimeVersion({ targetVersion: this.verifiedPlatformVersions[platform.toLowerCase()], platform, projectData })) {
164164
return true;
165165
}
166166
}
@@ -290,7 +290,7 @@ for more information, refer to the instructions in the following blog post: <lin
290290
for (const platform in this.$devicePlatformsConstants) {
291291
const lowercasePlatform = platform.toLowerCase();
292292
const hasRuntimeDependency = this.hasRuntimeDependency({ platform, projectData });
293-
if (!hasRuntimeDependency || await this.shouldUpdateRuntimeVersion({ targetVersion: this.verifiedPlatformVersions[lowercasePlatform], platform, projectData })) {
293+
if (hasRuntimeDependency && await this.shouldUpdateRuntimeVersion({ targetVersion: this.verifiedPlatformVersions[lowercasePlatform], platform, projectData })) {
294294
const verifiedPlatformVersion = this.verifiedPlatformVersions[lowercasePlatform];
295295
const platformData = this.$platformsDataService.getPlatformData(lowercasePlatform, projectData);
296296
this.$logger.info(`Updating ${platform} platform to version '${verifiedPlatformVersion}'.`);

0 commit comments

Comments
 (0)