Add check for not changing Chrome DevTools url/socket (cli #3183 and … #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
NOTE: Merge after PR 3281 is merged. |
dtopuzov
approved these changes
Jan 2, 2018
Natalia-Hristova
pushed a commit
that referenced
this pull request
Jan 8, 2018
Natalia-Hristova
deleted the
Natalia-Hristova/update-debug-ios-chrome-livesync
branch
dtopuzov
pushed a commit
that referenced
this pull request
Jan 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…#3261)
Get Chrome url first time debug is started and after change of a file.
Didn't put the check of the url in Tns.wait_for_log for 2 reasons: