Skip to content

fix: verify no errors during npm install #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 21, 2018
Merged

fix: verify no errors during npm install #132

merged 1 commit into from
May 21, 2018

Conversation

dtopuzov
Copy link
Contributor

The case:

  • We try to install nativescript-dev-sass@next which is not available.
  • Before this fix it will fail silently and project will use some old sass plugin version (or even it will hav eno sass plugin and it will fail)
  • Now we check if npm install is correct
  • This check may lead to failing tests where we install invalid version, but this will actually make our tests valid.

@dtopuzov
fix: verify no errors during npm install
515a1c7 
The case:
- We try to install nativescript-dev-sass@next which is not available.
- Before this fix it will fail silently and project will use some old sass plugin version (or even it will hav eno sass plugin and it will fail)
- Now we check if npm install is correct
- This check may lead to failing tests where we install invalid version, but this will actually make our tests valid.
vhristov5555
vhristov5555 approved these changes May 18, 2018
View reviewed changes
Copy link

@vhristov5555 vhristov5555 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if we should merge it before java 10 supported is fully tested. It is going to be harder to see errors. May lead to misunderstanding the problem of the test.

@dtopuzov dtopuzov merged commit bcaf246 into master May 21, 2018
@dtopuzov dtopuzov deleted the dtopuzov/verify-npm-install branch June 1, 2018 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vhristov5555 vhristov5555 vhristov5555 approved these changes

@miroslavaivanova miroslavaivanova Awaiting requested review from miroslavaivanova

@Natalia-Hristova Natalia-Hristova Awaiting requested review from Natalia-Hristova

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dtopuzov @vhristov5555