Skip to content

Commit 9218d46

Browse files
author
Natalia-Hristova
committed
Add TODOs for revert skipping after realse 4.1.0
1 parent 5f1d1e3 commit 9218d46

File tree

3 files changed

+9
-2
lines changed

3 files changed

+9
-2
lines changed

tests/build/android/build_android_tests.py

+4-1
Original file line numberDiff line numberDiff line change
@@ -162,6 +162,7 @@ def test_201_build_android_with_additional_prepare(self):
162162
TnsAsserts.prepared(self.app_name, platform=Platform.ANDROID, output=output, prepare=Prepare.INCREMENTAL)
163163
Tns.build_android(attributes={"--path": self.app_name})
164164

165+
# TODO: Remove skipping after release 4.1.0
165166
@unittest.skipIf(Java.version() != "1.8", "Run only if Java version is 8.")
166167
def test_202_build_android_with_log_trace_and_platform_not_added_or_empty(self):
167168
"""'tns build android' with log trace options should output more logs."""
@@ -410,10 +411,11 @@ def test_451_resources_update(self):
410411
assert File.exists(self.app_name + "/app/App_Resources/Android/src/main/res/values")
411412
Tns.build_android(attributes={"--path": self.app_name})
412413

414+
# TODO: Remove skipping after release 4.1.0
413415
@unittest.skipIf(Java.version() != "1.8", "Run only if Java version is 8.")
414416
def test_460_include_gradle_flavor(self):
415417
# https://github.com/NativeScript/android-runtime/pull/937
416-
# https: // github.com / NativeScript / nativescript - cli / pull / 3467
418+
# https://github.com/NativeScript/nativescript-cli/pull/3467
417419
Tns.platform_remove(platform=Platform.ANDROID, attributes={"--path": self.app_name},
418420
assert_success=False)
419421
source = os.path.join(TEST_RUN_HOME, 'data', 'issues', 'android-runtime-pr-937', 'app.gradle')
@@ -435,6 +437,7 @@ def test_460_include_gradle_flavor(self):
435437
assert File.exists(self.app_name +
436438
"/platforms/android/app/build/outputs/apk/x86Full/debug/app-x86-full-debug.apk")
437439

440+
# TODO: Remove skipping after release 4.1.0
438441
@unittest.skipIf(Java.version() != "1.8", "Run only if Java version is 8.")
439442
def test_461_include_gradle_flavor_update_resources(self):
440443
Tns.platform_remove(platform=Platform.ANDROID, attributes={"--path": self.app_name},

tests/build/android/platform_android_tests.py

+3
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ def setUp(self):
3131
BaseClass.setUp(self)
3232
Tns.platform_remove(platform=Platform.ANDROID, attributes={"--path": self.app_name}, assert_success=False)
3333

34+
# TODO: Remove skipping after release 4.1.0
3435
@unittest.skipIf(Java.version() != "1.8", "Run only if Java version is 8.")
3536
def test_100_platform_add_android(self):
3637
""" Default `tns platform add` command"""
@@ -40,6 +41,7 @@ def test_110_platform_add_android_framework_path(self):
4041
""" Add platform from local package"""
4142
Tns.platform_add_android(attributes={"--path": self.app_name, "--frameworkPath": ANDROID_PACKAGE})
4243

44+
# TODO: Remove skipping after release 4.1.0
4345
@unittest.skipIf(Java.version() != "1.8", "Run only if Java version is 8.")
4446
def test_120_platform_add_android_inside_project(self):
4547
""" Add platform inside project folder (not using --path)"""
@@ -74,6 +76,7 @@ def test_200_platform_update_android(self):
7476
Tns.platform_update(platform=Platform.ANDROID, version="2.5.0", attributes={"--path": self.app_name})
7577
TnsAsserts.package_json_contains(self.app_name, ["\"version\": \"2.5.0\""])
7678

79+
# TODO: Remove skipping after release 4.1.0
7780
@unittest.skipIf(Java.version() != "1.8", "Run only if Java version is 8.")
7881
def test_210_platform_update_android_when_platform_not_added(self):
7982
"""`platform update` should work even if platform is not added"""

tests/device/deploy_android_tests.py

+2-1
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,8 @@ def test_201_deploy_android_inside_project(self):
9292
for device_id in device_ids:
9393
assert device_id in output
9494

95-
@unittest.skipIf(Java.version() !="1.8", "Runonly if Java version is 8.")
95+
# TODO: Remove skipping after release 4.1.0
96+
@unittest.skipIf(Java.version() != "1.8", "Run only if Java version is 8.")
9697
def test_300_deploy_android_platform_not_added(self):
9798
Tns.create_app(app_name=self.app_name_noplatform)
9899
output = Tns.deploy_android(attributes={"--path": self.app_name_noplatform, "--justlaunch": ""}, timeout=240)

0 commit comments

Comments
 (0)