Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit 5f1d1e3

Browse files
author
vhristov5555
committedMay 21, 2018
Merge remote-tracking branch 'origin/master'
2 parents e86d501 + d780af0 commit 5f1d1e3

File tree

3 files changed

+14
-6
lines changed

3 files changed

+14
-6
lines changed
 

‎tests/build/android/build_android_tests.py

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -172,6 +172,7 @@ def test_202_build_android_with_log_trace_and_platform_not_added_or_empty(self):
172172
assert "[DEBUG]" in output
173173
assert "FAILURE" not in output
174174

175+
@unittest.skipIf(CURRENT_OS != OSType.OSX, "Run only on macOS.")
175176
def test_300_build_project_with_dash_and_ios_inspector_added(self):
176177
"""
177178
Verify we can build projects with dashes.
@@ -321,12 +322,13 @@ def test_406_build_release_without_key_options(self):
321322
output = Tns.build_android(attributes={"--release": "", "--path": self.app_name}, assert_success=False)
322323
assert "When producing a release build, you need to specify all --key-store-* options." in output
323324
assert "# tns build android" in output
324-
assert not File.exists(os.path.join(self.app_name, TnsAsserts.PLATFORM_ANDROID_APK_RELEASE_PATH, self.release_apk))
325+
assert not File.exists(
326+
os.path.join(self.app_name, TnsAsserts.PLATFORM_ANDROID_APK_RELEASE_PATH, self.release_apk))
325327

326328
def test_410_generated_classes_not_be_deleted_on_rebuild(self):
327329
# https: // github.com / NativeScript / nativescript - cli / issues / 3560
328330
Tns.platform_remove(platform=Platform.ANDROID, attributes={"--path": self.app_name},
329-
assert_success=False)
331+
assert_success=False)
330332
Tns.platform_add_android(attributes={"--path": self.app_name, "--frameworkPath": ANDROID_PACKAGE})
331333
target = os.path.join(self.app_name, 'app')
332334
source = os.path.join(TEST_RUN_HOME, 'data', 'issues', 'android-runtime-904', 'MyActivity.js')
@@ -364,7 +366,7 @@ def test_440_binding_text_exists(self):
364366
Folder.cleanup(self.app_ts_name)
365367

366368
def test_441_android_typings(self):
367-
#Build with --androidTypings got nothing #3381
369+
# Build with --androidTypings got nothing #3381
368370
Tns.run_tns_command("build android --androidTypings", attributes={"--path": self.app_name})
369371
assert File.exists(self.app_name + "/android.d.ts")
370372
assert File.exists(self.app_name + "/_helpers.d.ts")
@@ -410,10 +412,10 @@ def test_451_resources_update(self):
410412

411413
@unittest.skipIf(Java.version() != "1.8", "Run only if Java version is 8.")
412414
def test_460_include_gradle_flavor(self):
413-
#https://github.com/NativeScript/android-runtime/pull/937
414-
#https: // github.com / NativeScript / nativescript - cli / pull / 3467
415+
# https://github.com/NativeScript/android-runtime/pull/937
416+
# https: // github.com / NativeScript / nativescript - cli / pull / 3467
415417
Tns.platform_remove(platform=Platform.ANDROID, attributes={"--path": self.app_name},
416-
assert_success=False)
418+
assert_success=False)
417419
source = os.path.join(TEST_RUN_HOME, 'data', 'issues', 'android-runtime-pr-937', 'app.gradle')
418420
target = os.path.join(self.app_name, 'app', 'App_Resources', 'Android', 'app.gradle')
419421
File.copy(src=source, dest=target)

‎tests/regression/regression_tests_js.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,10 @@
11
import os
2+
import unittest
23

34
from core.base_class.BaseClass import BaseClass
45
from core.device.emulator import Emulator
56
from core.device.simulator import Simulator
7+
from core.java.java import Java
68
from core.osutils.folder import Folder
79
from core.osutils.os_type import OSType
810
from core.settings.settings import TEST_RUN_HOME, CURRENT_OS, SIMULATOR_NAME, \
@@ -13,6 +15,7 @@
1315
from tests.webpack.helpers.helpers import Helpers
1416

1517

18+
@unittest.skipIf(Java.version() != "1.8", "Run only if Java version is 8.")
1619
class RegressionTestsJS(BaseClass):
1720
SIMULATOR_ID = ""
1821

‎tests/regression/regression_tests_ng.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,10 @@
11
import os
2+
import unittest
23

34
from core.base_class.BaseClass import BaseClass
45
from core.device.emulator import Emulator
56
from core.device.simulator import Simulator
7+
from core.java.java import Java
68
from core.osutils.folder import Folder
79
from core.osutils.os_type import OSType
810
from core.settings.settings import TEST_RUN_HOME, CURRENT_OS, SIMULATOR_NAME, \
@@ -13,6 +15,7 @@
1315
from tests.webpack.helpers.helpers import Helpers
1416

1517

18+
@unittest.skipIf(Java.version() != "1.8", "Run only if Java version is 8.")
1619
class RegressionTestsNG(BaseClass):
1720
SIMULATOR_ID = ""
1821

0 commit comments

Comments
 (0)
Please sign in to comment.