Skip to content

revert(router): page navigation with RouteReuseStrategy #987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 13, 2017

Conversation

sis0k0
Copy link
Contributor

@sis0k0 sis0k0 commented Sep 12, 2017

Due to problems with lazy loaded routes.

Due to problems with lazy loaded routes.
@sis0k0 sis0k0 requested a review from vakrilov September 12, 2017 13:26
@ghost ghost assigned sis0k0 Sep 12, 2017
@ghost ghost added the in progress label Sep 12, 2017
@sis0k0
Copy link
Contributor Author

sis0k0 commented Sep 12, 2017

uitests

@NathanWalker
Copy link
Contributor

Hi @sis0k0 I'm curious if this fixes this issue on latest at moment when navigating to pages at times:

ERROR Error: Uncaught (in promise): TypeError: Cannot read property 'reusedRoute' of undefined
JS: TypeError: Cannot read property 'reusedRoute' of undefined
JS:     at PageRouterOutlet.activateOnGoBack (file:///data/data/com.ugroupmedia.pnp.client.mobile/files/app/tns_modules/nativescript-angular/router/page-router-outlet.js:270:18)
JS:     at PageRouterOutlet.activateWith (file:///data/data/com.ugroupmedia.pnp.client.mobile/files/app/tns_modules/nativescript-angular/router/page-router-outlet.js:217:18)
JS:     at ActivateRoutes.activateRoutes (file:///data/data/com.ugroupmedia.pnp.client.mobile/files/app/tns_modules/@angular/router/bundles/router.umd.js:4764:40)

If so, curious if any reasonable estimate on a merge to master? Just curious :)

@vakrilov
Copy link
Contributor

Hi @NathanWalker
This is just a revert of the changes form last week related to the router. They don't work when there is lazy loading involved, so we decided to revert the changes until we have a more stable implementation.

That said, I'm not sure which exactly is the issue you mentioned - is it logged?

@sis0k0 sis0k0 merged commit 421978e into master Sep 13, 2017
@sis0k0 sis0k0 deleted the vlaeva/revert-route-reuse-strategy branch September 13, 2017 07:55
@ghost ghost removed the in progress label Sep 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants