Skip to content

refactor(renderer): use singly linked list to keep track of NgElements #945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Aug 30, 2017
Merged

refactor(renderer): use singly linked list to keep track of NgElements #945

merged 20 commits into from
Aug 30, 2017

Conversation

sis0k0
Copy link
Contributor

@sis0k0 sis0k0 commented Aug 16, 2017 •
edited
Loading

fixes #924

@ghost ghost assigned sis0k0 Aug 16, 2017
@ghost ghost added the in progress label Aug 16, 2017
@sis0k0 sis0k0 closed this Aug 16, 2017
@sis0k0 sis0k0 reopened this Aug 16, 2017
@sis0k0 sis0k0 changed the title refactor(renderer): use singly linked list to keep track of NgElements [DON'T MERGE] refactor(renderer): use singly linked list to keep track of NgElements Aug 16, 2017
@sis0k0 sis0k0 force-pushed the vlaeva/renderer-siblings-refactor branch from 8fe8677 to 7d250f8 Compare August 25, 2017 11:29
@sis0k0 sis0k0 changed the title [DON'T MERGE] refactor(renderer): use singly linked list to keep track of NgElements refactor(renderer): use singly linked list to keep track of NgElements Aug 25, 2017
@sis0k0
test(e2e): fix examples for iOS
0090017 
Content views (Pages) cannot have multiple children and throw in iOS.
@sis0k0 sis0k0 requested a review from vakrilov August 28, 2017 08:25
@ghost ghost assigned vakrilov Aug 28, 2017
@sis0k0 sis0k0 force-pushed the vlaeva/renderer-siblings-refactor branch from 802d316 to 6f5d6f7 Compare August 29, 2017 16:55
@vakrilov
Copy link
Contributor

uitests

@vakrilov vakrilov merged commit fe672d2 into master Aug 30, 2017
@ghost ghost removed the in progress label Aug 30, 2017
@vakrilov vakrilov deleted the vlaeva/renderer-siblings-refactor branch August 30, 2017 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vakrilov vakrilov vakrilov approved these changes

Assignees

@vakrilov vakrilov

@sis0k0 sis0k0

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

renderer: attaching CommentNodes to visual tree causes problems
2 participants
@sis0k0 @vakrilov