Skip to content

fix(animations): enable routable animations #926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 2, 2017
Merged

fix(animations): enable routable animations #926

merged 1 commit into from
Aug 2, 2017

Conversation

sis0k0
Copy link
Contributor

@sis0k0 sis0k0 commented Aug 2, 2017

When querying for ng-components (natively represented by
ProxyViewContainers), the container's children are selected instead of
the container itself.

@sis0k0
fix(animations): enable routable animations
6e0fad8 
When querying for `ng-components` (natively represented by
`ProxyViewContainer`s), the container's children are selected instead of
the container itself.
@sis0k0 sis0k0 requested a review from vakrilov August 2, 2017 10:35
@sis0k0
Copy link
Contributor Author

sis0k0 commented Aug 2, 2017 •
edited
Loading

Sample application: https://github.com/NativeScript/ns-ng-routable-animations
Note: You need to install nativescript-angular from this branch.

@sis0k0 sis0k0 added this to the 4.2 milestone Aug 2, 2017
@sis0k0 sis0k0 requested a review from vchimev August 2, 2017 13:17
@vakrilov vakrilov merged commit e2e4f5a into master Aug 2, 2017
@vakrilov vakrilov deleted the vlaeva/router-animations branch August 2, 2017 13:51
@ghost ghost removed the ready for test label Aug 2, 2017
@jogboms
Copy link

jogboms commented Aug 17, 2017 •
edited
Loading

@sis0k0 I experienced an Issue since I upgraded to 4.2. I wrote about it here #941

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vakrilov vakrilov vakrilov approved these changes

@vchimev vchimev Awaiting requested review from vchimev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
3 participants
@sis0k0 @jogboms @vakrilov