-
-
Notifications
You must be signed in to change notification settings - Fork 241
fix(forms): add directives for formControl #861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(forms): add directives for formControl #861
Conversation
Can one of the admins verify this patch? |
2 similar comments
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
run ci |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Thanks for merging so quickly. Any idea when the next release is scheduled? Need this functionality for a project I am currently working on. |
Heya, the fix is available when using the |
Somewhat related to #576 and #526
At the moment, selectors only apply to
ngModel
andformControlName
meaning for Angular reactive forms to work with inputs, they must useformControlName
within aformGroup
directive.I would like to add
[formControl]
to the list of selectors so that reactive forms can be used without a parentformGroup
.Rationale:
Say you have a dumb component which implements an input:
Which is used by some parent component:
The above does not work with the latest
nativescript-angular
with the following error: "No value accessor for form control with unspecified name attribute".Adding the directives in the PR makes the above example work.