Skip to content

chore(deps): update nativescript-intl, remove @angular/animations from peerDeps #761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 19, 2017

Conversation

sis0k0
Copy link
Contributor

@sis0k0 sis0k0 commented Apr 19, 2017

  • remove @angular/animations from peerDeps
  • bump nativescript-intl version to 3.0

@sis0k0 sis0k0 requested review from vakrilov and vchimev April 19, 2017 08:35
sis0k0 added 2 commits April 19, 2017 14:31
@angular/animations are not required for every Angular applications.
When installing `nativescript-angular`, the user shouldn't see a warning
for unmet peer dependency if he's not using @angular/animations.
@sis0k0 sis0k0 force-pushed the vlaeva/peer-deps branch from 7d8bb67 to 570937a Compare April 19, 2017 11:32
@sis0k0 sis0k0 changed the title chore: remove @angular/animations from peerDeps, add TypeScript chore(deps): update nativescript-intl, remove @angular/animations from peerDeps Apr 19, 2017
Copy link
Contributor

@vakrilov vakrilov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@sis0k0 sis0k0 merged commit 20bd245 into release Apr 19, 2017
@sis0k0 sis0k0 deleted the vlaeva/peer-deps branch April 19, 2017 12:51
@vchimev vchimev removed their request for review June 8, 2017 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants