Support for Angular 4.0 based on tns-core-modules ~2.5 #711
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[email protected] turned action items into views and they can get removed as a part of the view detach process -- think *ngIf templates.
Gitignore is updated with files and folders from editors to exclude.
… OpaqueToken COMPILER_OPTIONS is no longer of type OpaqueToken. It is now an InjectionToken parameterized with object with property of type ViewEncapsulation. Introduced by: https://github.com/mhevery/angular/blame/e8778e59231f1a0f37f0ea847a6256398386fa41/tools/public_api_guard/core/index.d.ts#L224-L229
compliant with Angular API Introduced by: angular/angular@b4d444a
Needed in order to implement correctly the AnimationPlayer interface. Introduced by: angular/angular@4577b7c
COMPILER_OPTIONS now has a property of type MissingTranslationStrategy, which needs to be imported. Introduced by: https://github.com/angular/angular/blame/master/tools/public_api_guard/core/index.d.ts#L257
- Use RendererFactoryV2 instead of RootRenderer (NativeScriptRendererFactory) - Use RendererV2 for NativeScriptRenderer
Placeholders. - createComment - create new element "Comment" using ui/placeholder and attach it. These comments are used as anchors (nextSibling) for structural directives such as *ngIf and *ngFor. - createText - create new element "DetachedText" using ui/placeholder and don't attach it.
Needed to properly implement browser's DomAdapter. Caused by: angular/angular@a4076c7
revert after this fix: angular/angular#15300
same as #704 but using modules 2.5 style properties API's BREAKING CHANGE: To use animations, you need to import the NativeScriptAnimationsModule from "nativescript-angular/animations" in your root NgModule. Also you need a dependency to "@angular/animations".
Gitignore is updated with files and folders from editors to exclude.
Importing NativeScriptModule from "nativescript-angular/platform" leads to
including @angular/compiler in the bundle when doing AoT compilation
with webpack. Import from "nativescript-angular/nativescript.module"
should be used instead.
BREAKING CHANGE: User applications cannot import NativeScriptModule from
"nativescript-angular/platform" anymore.
Migration:
Before:
```
import { NativeScriptModule } from "nativescript-angular/platform";
```
After
```
import { NativeScriptModule } from
"nativescript-angular/nativescript.module";
```
Avoid a brief flash of a blank page on slower devices.
vchimev
approved these changes
Mar 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.