fix(bundling) Remove parse5 dependency. #660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hdeshev
force-pushed
the
hdeshev/no-parse5
branch
from
0e4924f to
8f801a3
Compare
Delete the parse5_adapter module. Create a dummy DOM adapter and register it for that code (*cough* @angular/router *cough*) that logs diagnostic messages via the DOM adapter. Register the DOM adapter dynamically, if and only if you can discover @angular/platform-browser. Hopefully one day @angular/router and @angular/http won't import @angular/platform-browser and we can strip it from the release bundle completely.
vakrilov
approved these changes
Feb 8, 2017
|
@NathanWalker No. |
|
Ok good to know - just checking, thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on the work done in #652 (and obsoletes it).
Delete the parse5_adapter module. Create a dummy DOM adapter and
register it for that code (cough @angular/router cough) that
logs diagnostic messages via the DOM adapter.
Register the DOM adapter dynamically, if and only if you can
discover @angular/platform-browser.
Hopefully one day @angular/router and @angular/http won't import
@angular/platform-browser and we can strip it from the release
bundle completely.
NOTE: Bundled production builds that have router tracing enabled will continue to crash. That seems like the reasonable tradeoff with removing the @angular/platform-browser dependency. Router tracing should be disabled in production builds anyway.