Skip to content

Emit loaded event after attaching to. #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 31, 2016
Merged

Emit loaded event after attaching to. #260

merged 1 commit into from
May 31, 2016

Conversation

nsndeck
Copy link
Contributor

@nsndeck nsndeck commented May 26, 2016

Emit loaded event just after attaching to it, but element is already loaded (due to some timings within an angular project).

@vakrilov
Copy link
Contributor

vakrilov commented May 30, 2016 •
edited
Loading

The change will fire the loaded whenever we attach a listener. Two concerns:

  1. This may happen long after the element was actually loaded.
  2. The fix will trigger other listeners that are currently listening for the loaded event.

@nsndeck nsndeck force-pushed the nnikolov/LoadedEventFix branch from 2f26ce2 to d0faa4e Compare May 31, 2016 08:31
@nsndeck nsndeck merged commit 19cbe4b into master May 31, 2016
@nsndeck nsndeck deleted the nnikolov/LoadedEventFix branch May 31, 2016 08:51
@nsndeck nsndeck mentioned this pull request May 31, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nsndeck @vakrilov